Skip to content

Fix workspaces reconciliation to send inventory config map correctly

Issue: Fix workspaces reconciliation to send inventory... (!187261 - merged)

What does this MR do and why?

Fix workspaces reconciliation to send inventory config map correctly. This is a backport to %17.10 for the Fix workspaces reconciliation to send inventory... (!187261 - merged) .

In cases where the workspace's desired state is not terminated(e.g. stopped) and where we perform a partial reconciliation, we are currently sending both the inventory config maps and no actual secrets(since it is partial reconciliation). This results in the deletion of the actual secrets which are to be mounted as files/environment-variables(this is expected behaviour). When you now try to start the stopped workspace, it fails because the expected secrets are not available. They will only become available when a full reconciliation happens.

This was introduced in !183632 (diffs) .

This MR fixes the specs first and then the domain logic where the final resultant is as follows

  • When it is a partial reconciliation, the config to apply are the core inventory configmap, deployment, service, service account, network policy.
  • When it is a full reconciliation, the config to apply are the core inventory configmap, deployment, service, service account, network policy, secrets inventory config map, resource quota, secrets(which are to be mounted as environment variables), secrets(which are to be mounted as files)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Screenshots or screen recordings

Before fixing

Screen_Recording_2025-04-10_at_3.20.46_PM

After fixing

Screen_Recording_2025-04-10_at_3.16.53_PM

How to set up and validate locally

  1. Create a workspace.
  2. Stop the workspace.
  3. Start the workspace again and open it up when it is ready.
  4. Terminate the workspace.
Edited by Vishal Tak

Merge request reports

Loading