Skip to content

Fe fix karma vue test utils violations

Scott Stern requested to merge fe-fix-karma-vue-test-utils-violations into master

What does this MR do?

Closes #32213 (closed) by fixing violations to the following Karma + vue-test-utils rules:

  • Must add sync: false
  • Must create localVue and use this to extend component

Why are these rules needed?

  • gitlab-foss#56317 (moved)
  • sync: true is the default but going away in a later release of vue-test-utils because it's buggy.

Wait... So why are they needed?

Without these rules, vue-test-utils + Karma causes some non-deterministic unrelated failures that look like forever loops, such as this #32213 (closed).

/cc @pslaughter

Edited by Paul Slaughter

Merge request reports