Rename notification for being added as approver
What does this MR do and why?
It's unclear when "Added as MR approver" notification is sent.
Answer: when an MR you're eligible to approve, via CODEOWNERS, but maybe not only, is created. The email isn't necessarily sent immediately.
Related: #451899 (comment 1830701415)
Additionally, email text could be improved at the same time: #451899 (comment 2431710413)
This clarifies what triggers the notification.
References
- Implements Improve email notification issues documentation... (#465347 - closed)
- Related to #12855 (closed)
Screenshots or screen recordings
Notification settings > Custom
| Before | After |
|---|---|
|
|
Notification email
| Before | After |
|---|---|
| Jon Doe has added you as an approver. | Jon Doe has created a merge request that you can approve. |
To-do item
| Before | After |
|---|---|
| Jon Doe set you as an approver. | Jon Doe created a merge request that you can approve. |
How to set up and validate locally
To preview the changed setting:
- On the left sidebar, select your avatar.
- Select Preferences.
- On the left sidebar, select Notifications.
- Select your global or any project's notification level, and select Custom.
To preview the email template:
- I don't know
🤷 I couldn't find it among other emails at http://gdk.test:3000/rails/mailers.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #465347 (closed)
Edited by Marcin Sedlak-Jakubowski