Skip to content

Fix empty charts in collapsed sections

What does this MR do?

On the initial load, some collapsible sections in the monitor dashboard are rendered closed. The charts within such sections are empty. This is because the chart's width is set based on its parent's width. However, the closed collapsible sections do not render the section body on the DOM thus setting the chart's width to 0.

I used the Gitlab-UI's resize-observer on chart's parent container. Because these containers resize using bootstraps classes based on window size, listening to Window's resize is not necessary.

Screen recording

screen_resize_1

Mobile Screen recording

mobile_screens

Screenshots

Before After
before_charts_hidden after_charts_hidden

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #33268 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports