Skip to content

Visual Review API

drew stachon requested to merge drew/gitlab:visual-review-api into master

What does this MR do?

This MR creates a new endpoint specifically for posting feedback from Visual Review Tools without authentication, specified in #29067 (closed). Comments are normally posted through a somewhat type-agnostic notables API, so I created a different endpoint to minimize the scope of unauthenticated functionality.

Comments are owned by the Visual Review Bot, added in !18663 (merged). The commit from the MR is included in this branch, and this MR should be merged after !18663 (merged).

This was opened first, but a non-fork MR with the full MR Pipeline can be found here: !18710 (merged)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jackie Porter

Merge request reports