[FIX] Refactor Vue components to remove unused properties and update ESLint rules
Issue: Address `vue/no-unused-properties` violations i... (#525829 - closed) • David Wagih • 17.11
Description
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do and why?
This MR addresses the vue/no-unused-properties violations in the following files:
ee/app/assets/javascripts/workspaces/common/components/workspaces_list/workspaces_table.vueee/app/assets/javascripts/workspaces/dropdown_group/components/workspace_dropdown_item.vueee/app/assets/javascripts/workspaces/user/pages/list.vue
Changes made:
- Added eslint-disable comments for public API properties in
workspaces_table.vue:tabsModetransitionPropsdevfileRefAndPathDisplayisTerminated
- Removed unused
dropdownItemcomputed property fromworkspace_dropdown_item.vue - Added back
userWorkspacesTabListinlist.vueas it's required for Apollo query management
References
- Original issue: #525829 (closed)
- Related ESLint rule: vue/no-unused-properties
Screenshots or screen recordings
No UI changes were made in this MR. The changes are purely related to code quality and linting improvements.
How to set up and validate locally
-
Check out the branch and install dependencies:
git checkout feature/address-vue-no-unused-properties-violations yarn install -
Run ESLint on the modified files to verify the fixes:
yarn lint:eslint ee/app/assets/javascripts/workspaces/common/components/workspaces_list/workspaces_table.vue ee/app/assets/javascripts/workspaces/dropdown_group/components/workspace_dropdown_item.vue ee/app/assets/javascripts/workspaces/user/pages/list.vue -
Verify that no
vue/no-unused-propertieswarnings are shown for these files
MR acceptance checklist
-
Code quality -
ESLint violations fixed -
Proper documentation added for disabled ESLint rules -
No new warnings introduced
-
-
Testing -
Existing functionality remains unchanged -
No regressions introduced
-
-
Documentation -
Added clear comments explaining why ESLint rules are disabled -
MR description explains changes and validation steps
-
References
Screenshots or screen recordings
| Before | After |
|---|---|
How to set up and validate locally
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Chad Woolley