Skip to content

No-op ci_runner_machines_687967fa8a batched migrations

What does this MR do and why?

This MR no-ops and cleans up the following 2 migrations:

  • 20241107064635_queue_backfill_ci_runner_machines_partitioned_table.rb: ci_runner_machines_687967fa8a table backfill migration, which executed on GitLab.com in %17.7 and was finalized in %17.9.

    The backfill on this table is causing issues due to a problem in the timing of the post-deployment migrations:

    1. 20241107064635_queue_backfill_ci_runner_machines_partitioned_table
    2. 20241211072300_retry_add_fk_from_p_ci_runner_managers_to_p_ci_runners
    3. 20241219100359_requeue_backfill_ci_runners_partitioned_table

    Migration 2 installs a FK check before the target table (ci_runners_e59bb2812d) is backfilled in migration 3, so we have #520092 (closed). We can afford to not backfill ci_runner_machines_687967fa8a, since it'll be populated with runner data automatically as they request jobs from the GitLab instance.

  • 20250113164152_requeue_delete_orphaned_partitioned_ci_runner_machine_records.rb which was scheduled in 17.9, but might not be finished when 20250307080000_replace_ci_runners_machines_with_partitioned_table.rb (from 17.10) runs and renames the table.

Changelog: other

Backports:

  • %17.10: !185304 (merged) (no-ops 20250113164152_requeue_delete_orphaned_partitioned_ci_runner_machine_records.rb, introduces 20250307070000_cleanup_delete_orphaned_partitioned_ci_runner_machine_records.rb and 20250307070001_cleanup_requeue_delete_orphaned_partitioned_ci_runner_machine_records.rb)
  • %17.9: !185303 (merged) (no-ops 20250113164152_requeue_delete_orphaned_partitioned_ci_runner_machine_records.rb and introduces 20250307070000_cleanup_delete_orphaned_partitioned_ci_runner_machine_records.rb)
  • %17.8: !185302 (merged) (no-ops 20241107064635_queue_backfill_ci_runner_machines_partitioned_table)

References

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports

Loading