Skip to content

Fix showing diff when it has legacy diff notes

Patrick Bajao requested to merge 27715-fix-unrenderable-notes into master

What does this MR do?

Do not try to unfold LegacyDiffNotes as they don't support position even though they're in the same notes table as DiffNotes.

This is done by using Gitlab::Diff::PositionCollection which will be responsible for filtering the positions.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#27715 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports