Don't add duplicate emojis to emoji cache
What does this MR do and why?
There's a race condition that may try to push duplicate emojis to the emoji cache for work item awards. This change prevents those duplicates from being persisted to the cache.
References
- ✂️ UX Paper Cuts 17.11 → Verify (#512693 - closed)
- Work items - Comment reactions can appear as if... (#518032 - closed)
Screenshots or screen recordings
| Before | After |
|---|---|
| Screen_Recording_2025-03-19_at_12.45.32 | Screen_Recording_2025-03-19_at_12.45.04 |
How to set up and validate locally
- Check out this branch
- Visit a work item in the GDK
- If necessary, add a comment
- Use devtools to throttle your network speed -- the race condition this fixes is best reproduced when network speeds are slow
- Add an emoji reaction to a comment via the note actions emoji picker in the header area of the comment
- You will see that the count of reactions for that emoji is correct, and after graphql calls in the network tab of devtools resolve, the count will remain correct
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #518032 (closed)
Edited by Chad Lavimoniere