Fix undefined method errors when DNS lookup fails (!18494) · Merge requests · GitLab.org / GitLab · GitLab

Stan Hu requested to merge sh-fix-dns-undefined-errors into master Oct 12, 2019

net-dns has a bug (https://github.com/bluemonk/net-dns/issues/46) that causes this error to hit whenever the nameserver lookup via TCP times out. To fix this problem in the short term, use our fork of this repository and pull in the fix (https://gitlab.com/gitlab-org/gitlab-net-dns/merge_requests/2).

The new exception, Net::DNS::NoResponseError, will now be reported instead.

The full diff: https://gitlab.com/gitlab-org/gitlab-net-dns/compare/v0.9.0...v0.9.1

Closes #11634 (closed)

Edited Oct 12, 2019 by Stan Hu