Add spec for filtering by multiple authors
What does this MR do?
Adds a spec to todo finder specs.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.4
added GraphQL api backend devopsplan groupproject management workflowin dev labels
added backstage [DEPRECATED] maintenancerefactor labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Sean Carroll ( @sean_carroll
)Michael Kozono ( @mkozono
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖@sean_carroll Could you review these changes? Thank you
assigned to @sean_carroll and unassigned @pderichs
- Resolved by Patrick Derichs
Thanks @pderichs just a minor nitpick.
assigned to @pderichs and unassigned @sean_carroll
added 46 commits
-
3581d814...ac87fecb - 45 commits from branch
master
- a5d3f1bf - Add spec for filtering by multiple authors
-
3581d814...ac87fecb - 45 commits from branch
Thanks @sean_carroll - the "nitpick" was totally justified
I have updated the MR. Could you have a look? Thank youassigned to @sean_carroll and unassigned @pderichs
@pderichs glad I could help. LGTM.
assigned to @pderichs and unassigned @sean_carroll
Thanks @sean_carroll
@mkozono Could you review these changes? Thank you
@pderichs LGTM! I’m AFK but I can merge this when conflicts are resolved. Thanks!
added 155 commits
-
a5d3f1bf...f5bf17c9 - 154 commits from branch
master
- 62b45829 - Add spec for filtering by multiple authors
-
a5d3f1bf...f5bf17c9 - 154 commits from branch
Thanks @mkozono! I have resolved the merge conflict
Sorry for any inconvenience. Could you have a look? Thank youmentioned in commit c35745fd
@pderichs Thanks! CI is kind of messed up today but this seems very safe :) Merged!
mentioned in commit Dalahro/gitlab@4d1a3d31