Skip to content
Snippets Groups Projects

Add spec for filtering by multiple authors

All threads resolved!

What does this MR do?

Adds a spec to todo finder specs.

#31914 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#31914 (closed)

Edited by Patrick Derichs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @pderichs just a minor nitpick.

  • Sean Carroll assigned to @pderichs and unassigned @sean_carroll

    assigned to @pderichs and unassigned @sean_carroll

  • Patrick Derichs added 46 commits

    added 46 commits

    Compare with previous version

  • Patrick Derichs resolved all threads

    resolved all threads

  • Author Contributor

    Thanks @sean_carroll - the "nitpick" was totally justified :slight_smile: I have updated the MR. Could you have a look? Thank you :bow:

  • assigned to @sean_carroll and unassigned @pderichs

  • @pderichs glad I could help. LGTM.

  • Sean Carroll approved this merge request

    approved this merge request

  • Sean Carroll assigned to @pderichs and unassigned @sean_carroll

    assigned to @pderichs and unassigned @sean_carroll

  • Author Contributor

    Thanks @sean_carroll :bow:

    @mkozono Could you review these changes? Thank you :bow:

  • Patrick Derichs assigned to @mkozono and unassigned @pderichs

    assigned to @mkozono and unassigned @pderichs

  • Michael Kozono approved this merge request

    approved this merge request

  • @pderichs LGTM! I’m AFK but I can merge this when conflicts are resolved. Thanks!

  • Michael Kozono assigned to @pderichs and unassigned @mkozono

    assigned to @pderichs and unassigned @mkozono

  • Patrick Derichs added 155 commits

    added 155 commits

    Compare with previous version

  • Author Contributor

    Thanks @mkozono! I have resolved the merge conflict :thumbsup: Sorry for any inconvenience. Could you have a look? Thank you :bow:

  • Patrick Derichs assigned to @mkozono and unassigned @pderichs

    assigned to @mkozono and unassigned @pderichs

  • Michael Kozono mentioned in commit c35745fd

    mentioned in commit c35745fd

  • @pderichs Thanks! CI is kind of messed up today but this seems very safe :) Merged! :rocket:

  • Please register or sign in to reply
    Loading