Skip to content

compare timestamps to prevent webhook firing before creation

What does this MR do?

if a webhook is created after a commit is pushed, sometimes it would still fire. This MR compares timestamps of two events and only allow webhook to fire if webhook is created before latest git push.

Screenshots

I used hook.js nodejs script to test. Logic is described in #33738 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #33738 (closed)

Edited by Nick Thomas

Merge request reports