Skip to content

Prevent /set_parent command on CE work item issues

Matt D'Angelorequested to merge
mdangelo/prevent_set_parent_quick_action_for_work_item_issues_in_ce into master

What does this MR do and why?

The changes in this MR have split from !183446 (merged), where a comment identified that in CE, the /set_parent command is available on work item issues. This should not be the case, as issue work item parents should only be available in EE.

The changes here move this check from EE into CE, preventing the command from being displayed.

References

MR acceptance checklist

  • You have self-reviewed this MR per code review guidelines.
  • The code follows the software design guidelines.
  • Ensure automated tests exist following the testing pyramid. Add missing tests or create an issue documenting testing gaps.
  • You have considered the technical impacts on GitLab.com, Dedicated and self-managed.
  • You have considered the impact of this change on the frontend, backend, and database portions of the system where appropriate and applied the ~ux, frontend, backend, and database labels accordingly.
  • You have tested this MR in all supported browsers, or determined that this testing is not needed.
  • You have confirmed that this change is backwards compatible across updates, or you have decided that this does not apply.
  • You have properly separated EE content (if any) from FOSS. Consider running the CI pipelines in a FOSS context.
  • You have considered that existing data may be surprisingly varied. For example, if adding a new model validation, consider making it optional on existing data.
  • You have fixed flaky tests related to this MR, or have explained why they can be ignored. Flaky tests have error Flaky test '<path/to/test>' was found in the list of files changed by this MR. but can be in jobs that pass with warnings.

Screenshots or screen recordings

On an issue work item:

Before After
CE before_ce after_ce
EE before_ee after_ee

How to set up and validate locally

  1. In a CE instance, navigate to a work item issue
  2. Attempt to execute the /set_parent command, by typing this into the comment or description fields
  3. Observe that /set_parent is no longer an option in CE
Edited by Matt D'Angelo

Merge request reports