Handle ActiveRecord::RecordNotDestroyed: Projects::Ml::CandidatesController#destroy

Fred de Gierrequested to merge
515936-activerecord-recordnotdestroyed-projects-ml-candidatescontroller-destroy into master

What does this MR do and why?

This MR fixes a bug where in some cases a Run (candidate) could not be destroyed raising an active record error.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Checkout the default branch in GDK, cherry pick the changes from this MR in file spec/requests/projects/ml/candidates_controller_spec.rb
  2. Run the specs: spec/requests/projects/ml/candidates_controller_spec.rb
  3. Verify the active record error is present
  4. Cherry pick the changes in app/controllers/projects/ml/candidates_controller.rb or checkout the branch of this MR
  5. Run the specs again and verify they pass

Numbered steps to set up and validate the change are strongly suggested.

Related to #515936 (closed)

Edited by Fred de Gier

Merge request reports