Skip to content

Rename workhorse acceleration in development documentation

Alessio Caiazza requested to merge ac-follow-up-from-document-uploads-development-guidelines into master

What does this MR do?

Rename workhorse acceleration in development documentation:

  • Workhorse disk acceleration => Disk buffered upload
  • Workhorse object storage acceleration => Direct upload

From #31198 (closed)

The reason I used Workhorse disk acceleration is because this is the name of that feature in workhorse codebase, and being this a development guide, I was trying to point engineers into the right direction code-wise.

This are not user-facing features, but development optimization we have in place and are meant to be consumed by backend engineers and contributors.

WDYT of:

  • Regular rails upload
  • Workhorse disk acceleration => Disk acceleration
  • Workhorse object storage acceleration => Inline object storage upload (there's no reference to 'acceleration' in workhorse codebase for this feature)

I'll prefer to avoid any reference of direct to not create confusion with direct_upload setting, but also direct object storage upload could be a good name.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Closes #31198 (closed)

Edited by Marin Jankovski

Merge request reports