Skip to content
Snippets Groups Projects

Fix accessibility of Whats New drawer headers

Merged Chad Lavimoniere requested to merge 474113-fix-whats-new-semantic-html into master

What does this MR do and why?

Fix accessibility of Whats New drawer headers

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2025-02-25_at_15.05.16 Screenshot_2025-02-25_at_15.04.59

How to set up and validate locally

  1. Check out this branch in the GDK
  2. Visit the GDK
  3. Open the "What's new" drawer by going to Help > What's new in the bottom of the left sidebar
  4. Inspect the "What's new" header in dev tools. You will see that it uses an H2 semantic element.
  5. Inspect the link to a feature in dev tools. You will see that it is a link inside an H3 semantic element.

Related to #474113 (closed)

Merge request reports

Merge train pipeline #1689216588 passed

Merge train pipeline passed for cb89de46

Merged by Tristan ReadTristan Read 1 month ago (Feb 26, 2025 10:10am UTC)

Loading

Pipeline #1689218788 passed

Pipeline passed for 8b0b31a6 on master

10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading