Fix accessibility of Whats New drawer headers
What does this MR do and why?
Fix accessibility of Whats New drawer headers
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- Follow-up from "Use tailwind util classes for s... (#474113 - closed)
- ✂️ UX Paper Cuts 17.10 → Accessibility & AI Age... (#512691 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch in the GDK
- Visit the GDK
- Open the "What's new" drawer by going to Help > What's new in the bottom of the left sidebar
- Inspect the "What's new" header in dev tools. You will see that it uses an
H2
semantic element. - Inspect the link to a feature in dev tools. You will see that it is a link inside an
H3
semantic element.
Related to #474113 (closed)
Merge request reports
Activity
changed milestone to %17.10
assigned to @clavimoniere
added pipelinetier-1 label
added frontend label
2 Warnings ⚠️ This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.⚠️ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/whats_new/components/feature.vue
- data-testid="whats-new-item-link" - <h5 class="gl-my-0 gl-text-lg" data-testid="feature-name">{{ feature.name }}</h5> + <h3 class="gl-mb-1 gl-mt-4 gl-text-lg" data-testid="feature-name"> + data-testid="whats-new-item-link"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @smaglangit
(UTC+8, 13 hours ahead of author)
@tristan.read
(UTC+13, 18 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by ****- Resolved by Tristan Read
@tristan.read can you do a frontend maintainer review on this? Should be just semantics with no apparent change in the UI.
requested review from @tristan.read
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Tristan Read
Just checking to see if any e2e tests reference
"feature-name"
...
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f802775a and 07ab9343
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.88 MB 4.88 MB - 0.0 % mainChunk 3.78 MB 3.78 MB - 0.0 %
Note: We do not have exact data for f802775a. So we have used data from: c198a89e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by ****