Skip to content
Snippets Groups Projects

Adjust placeholder to solve misleading regex

Merged Samantha Ming requested to merge 12564-email-regex into master
All threads resolved!

Issue: #12564 (closed)

What does this MR do?

Update placeholder to better reflect current regex rule

image

Test Case

Note a starter license is required for the Push Rules

  1. Navigate to your project’s Settings > Repository and expand Push Rules
  2. In the Commit author's email, the placeholder should read:
  • Example: @sub\.company\.com$

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #12564 (closed)

Edited by Samantha Ming

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Samantha Ming added 1 commit

    added 1 commit

    • 70184f94 - Adjust placeholder to solve misleading regex

    Compare with previous version

  • Samantha Ming resolved all threads

    resolved all threads

  • @wortschi do you mind doing the maintainer review :smile:

  • assigned to @wortschi

  • Samantha Ming resolved all threads

    resolved all threads

  • Samantha Ming added 1 commit

    added 1 commit

    • dfe079be - Adjust placeholder to solve misleading regex

    Compare with previous version

  • assigned to @ahegyi

  • unassigned @wortschi and @ahegyi

  • assigned to @wortschi

  • Samantha Ming resolved all threads

    resolved all threads

  • mentioned in issue #33942 (closed)

  • Samantha Ming added 1 commit

    added 1 commit

    • ca096062 - Adjust placeholder to solve misleading regex

    Compare with previous version

  • Samantha Ming added 1 commit

    added 1 commit

    • 881dd5f9 - Adjust placeholder to solve misleading regex

    Compare with previous version

  • Samantha Ming added 1 commit

    added 1 commit

    • 7c777ca6 - Adjust placeholder to solve misleading regex

    Compare with previous version

  • Samantha Ming added 1 commit

    added 1 commit

    • 36dfa69c - Adjust placeholder to solve misleading regex

    Compare with previous version

  • assigned to @wortschi

  • Martin Wortschack approved this merge request

    approved this merge request

  • Martin Wortschack resolved all threads

    resolved all threads

  • mentioned in commit f8caaee4

  • This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.4.201910171510-ac38081b602.8a20b2fd697.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • This merge request has been deployed to the GitLab.com environment gprd-cny in GitLab auto-deploy version 12.4.201910171510-ac38081b602.8a20b2fd697.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowcanary label and removed workflowstaging label

  • This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.4.201910171510-ac38081b602.8a20b2fd697.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading