Adjust placeholder to solve misleading regex
Issue: #12564 (closed)
What does this MR do?
Update placeholder to better reflect current regex rule
Test Case
Note a starter license is required for the Push Rules
- Navigate to your project’s Settings > Repository and expand Push Rules
- In the Commit author's email, the placeholder should read:
-
Example: @sub\.company\.com$
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #12564 (closed)
Merge request reports
Activity
changed milestone to %12.4
2 Warnings Please add a throughput label to this merge request. You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Dave Pisek ( @dpisek
)Tim Zallmann ( @timzallmann
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 91 commits
-
e0ea9b51...bb18b759 - 90 commits from branch
master
- ee790d8a - Adjust placeholder to solve misleading regex
-
e0ea9b51...bb18b759 - 90 commits from branch
- Resolved by Samantha Ming
@thomasrandolph do you mind reviewing this (just a placeholder change)
Edited by Samantha Ming
assigned to @dietrichstein
added 1 commit
- 0863d99a - Adjust placeholder to solve misleading regex
assigned to @thomasrandolph
unassigned @dietrichstein
- Resolved by Samantha Ming
unassigned @thomasrandolph
added 1 commit
- 70184f94 - Adjust placeholder to solve misleading regex
assigned to @thomasrandolph
- Resolved by Samantha Ming
LGTM
unassigned @thomasrandolph
@wortschi do you mind doing the maintainer review
assigned to @wortschi
added 1 commit
- dfe079be - Adjust placeholder to solve misleading regex
- Resolved by Samantha Ming
- Resolved by Martin Wortschack
@sming-gitlab Great work! Just one question, let's see what BE suggests in this case. Once this is resolved I can merge.
Edited by Martin Wortschack
assigned to @ahegyi
assigned to @wortschi
unassigned @wortschi
mentioned in issue #33942 (closed)
added 1 commit
- ca096062 - Adjust placeholder to solve misleading regex
added 1 commit
- 881dd5f9 - Adjust placeholder to solve misleading regex
added 1 commit
- 7c777ca6 - Adjust placeholder to solve misleading regex
added 1 commit
- 36dfa69c - Adjust placeholder to solve misleading regex
assigned to @wortschi
mentioned in commit f8caaee4
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.4.201910171510-ac38081b602.8a20b2fd697
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.4.201910171510-ac38081b602.8a20b2fd697
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.4.201910171510-ac38081b602.8a20b2fd697
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
mentioned in commit Dalahro/gitlab@4d1a3d31