Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,108
    • Issues 43,108
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,356
    • Merge requests 1,356
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !18193

Make SAST compatible with private dependencies via ENV propagation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Victor Zagorodny requested to merge 11137-propagate-all-env-vars-to-sast-containers into master Oct 07, 2019
  • Overview 40
  • Commits 1
  • Pipelines 17
  • Changes 3

What does this MR do?

It propagates all custom ENV vars to the underlying SAST analyzer Docker images and enables using credentials for external Git repos or other dependencies required by projects scanned by SAST analyzers. Thus, this MR makes SAST compatible with private dependencies.

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • [-] Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • Separation of EE specific content

Performance and Testing

  • [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited Oct 07, 2019 by Victor Zagorodny
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 11137-propagate-all-env-vars-to-sast-containers