Make SAST compatible with private dependencies via ENV propagation (!18193) · Merge Requests · GitLab.org / GitLab

Make SAST compatible with private dependencies via ENV propagation

What does this MR do?

It propagates all custom ENV vars to the underlying SAST analyzer Docker images and enables using credentials for external Git repos or other dependencies required by projects scanned by SAST analyzers. Thus, this MR makes SAST compatible with private dependencies.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

[-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
[-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

[-] Label as security and @ mention @gitlab-com/gl-security/appsec
[-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
[-] Security reports checked/validated by a reviewer from the AppSec team

## What does this MR do?

It propagates all [custom ENV vars](https://docs.gitlab.com/ee/ci/variables/README.html#creating-a-custom-environment-variable) to the underlying SAST analyzer Docker images and enables using credentials for external Git repos or other dependencies required by projects scanned by SAST analyzers. Thus, this MR [makes SAST compatible with private dependencies](#11137).

## Does this MR meet the acceptance criteria?

### Conformity

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) 
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) or [follow-up review issue created](https://gitlab.com/gitlab-org/gitlab-ce/issues/new?issuable_template=Doc%20Review)
- [x] [Code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [-] [Merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] [Style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/contributing/style_guides.md)
- [-] [Database guides](https://docs.gitlab.com/ee/development/README.html#database-guides)
- [x] [Separation of EE specific content](https://docs.gitlab.com/ee/development/ee_features.html#separation-of-ee-code)

### Performance and Testing

- [-] [Review and add/update tests for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html). Consider [all test levels](https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html). See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/test-engineering).
- [-] [Tested in all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)

### Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in [the security review guidelines](https://about.gitlab.com/handbook/engineering/security/#when-to-request-a-security-review):

- [-] Label as ~security and @ mention `@gitlab-com/gl-security/appsec`
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team

Edited Oct 07, 2019 by Victor Zagorodny