Skip to content

Resolve UpdateStatisticsService rubocop warning

Hunter Stewartrequested to merge
519760-update-statistics-service into master

Why

We are currently ignoring a Rubocop warning about service responses because of the response in 'app/services/snippets/update_statistics_service.rb'

What

  • remove ignore warning
  • update response to comply with rubocop guidelines
  • update specs
  • grepped for usagse to if anything was relying on the response content implementation, but didn't see anything

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #519760 (closed)

Edited by Hunter Stewart

Merge request reports