Pin honnef.co/go/tools/cmd/staticcheck v0.5.1

What does this MR do and why?

Pin honnef.co/go/tools/cmd/staticcheck v0.5.1

See gitlab-org/quality/engineering-productivity/master-broken-incidents#10443 (comment 2343355904) . This library just bumped go.mod to require go 1.23 and it's breaking our CI pipeline.

See Slack discussion (internal). It's not ideal to depend on @latest but also less than ideal to be dynamically installing these dependencies in CI which makes the problems only appear later on.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to Wednesday 2025-02-12 02:07 UTC - `gitlab-org/gi... (gitlab-org/quality/engineering-productivity/master-broken-incidents#10443 - closed)

Edited by Dylan Griffith

Merge request reports

Loading