Fix: Removing all domains does not reset primary domain
What does this MR do and why?
Fix: Removing all domains does not reset primary domain
Related: #514767 (closed)
Changelog: fixed
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
- Initialize a generic
Pages/Plain HTMLproject from template - Run a pipeline to deploy pages
- Go to Deploy > Pages > New Domain
- Enter in any fake domain and ignore the SSL requirements. Save Changes.
- Select the new fake domain under the
Primary domaindropdown. Save Changes. - Delete the newly created fake domain under
Domains - Use the API endpoint
https://gitlab.com/api/v4/projects/PROJECT_ID/pagesto check thepages_primary_domain. It should be reset.
Edited by Naman Jagdish Gala