Advanced search: Cleanup sections

changed milestone to %17.9

added UX UX Paper Cuts frontend maintenancerefactor sectiondev typemaintenance labels

added devopsfoundations groupux paper cuts labels

added sectioncore platform label and removed sectiondev label

added backend label

	2 Warnings
⚠️	This MR changes code in `ee/`, but its Changelog commit is missing the `EE: true` trailer. Consider adding it to your Changelog commits.
⚠️	This merge request is quite big (542 lines changed), please consider splitting it into multiple merge requests.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@schmil.monderer` (UTC+2, 1 hour ahead of author)	`@vij` (UTC+0, 1 hour behind author)
frontend	`@fernanda.toledo` (UTC-8, 9 hours behind author)	`@pgascouvaillancourt` (UTC-5, 6 hours behind author)
UX	`@jmiocene` (UTC+1, same timezone as author)	Maintainer review is optional for UX

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

Hey 👋

@annabeldunstone can you do the UX review?

TY

requested review from @annabeldunstone

resolved all threads

In light mode there's a double bottom border on the cards:

Non-blocking thought:

Could we get rid of these icons? This one looks like it should be a button 😅

I like that the shards/replicas have been moved into a crud component 👏 but could we remove the top border on the table?

removed review request for @annabeldunstone

added 1 commit

fa453057 - Advanced search: Cleanup sections

Compare with previous version

requested review from @jmiocene

added 1 commit

89953969 - Advanced search: Cleanup sections

Compare with previous version

added 1 commit

be83f3f4 - Advanced search: Cleanup sections

Compare with previous version

approved this merge request

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

🛠️ Generated by gitlab_quality-test_tooling.

🐌 Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#9073823604	`ee/spec/features/search/zoekt/search_spec.rb#L33`	Zoekt search finds files with a regex search and allows filtering down again by project	89.45 s	< 50.13 s

added rspec:slow test detected label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: ✅ test report for be83f3f4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 135    | 0      | 23      | 0     | 158   | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Govern      | 78     | 0      | 14      | 0     | 92    | ✅     |
| Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
| Verify      | 51     | 0      | 21      | 0     | 72    | ✅     |
| Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 425    | 0      | 130     | 0     | 555   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: ✅ test report for be83f3f4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Govern      | 83     | 0      | 11      | 0     | 94    | ✅     |
| Verify      | 52     | 0      | 20      | 0     | 72    | ✅     |
| Create      | 140    | 0      | 22      | 0     | 162   | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 443    | 0      | 128     | 0     | 571   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

Hey @jmontal can you take a look at the frontend changes here?

requested review from @jmontal

resolved all threads

requested review from @dzubova and removed review request for @jmontal

requested review from @dpisek and removed review request for @dzubova

approved this merge request

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label

requested review from @pgascouvaillancourt

This is looking good @seggenberger! I have an almost-blocking question regarding the use of a min-width CSS util with an arbitrary value. It's minor enough that I think I'll merge this anyways, but please do follow-up on that question if it's relevant 🙏

approved this merge request

resolved all threads

enabled automatic add to merge train when checks pass

added this merge request to the merge train at position 2

merged

mentioned in commit db115ba9

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

Before	After
Advanced Search

Indexing status

Advanced search: Cleanup sections

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

Activity

Reviewer roulette

Before you set this MR to auto-merge

E2E Test Result Summary

Advanced search: Cleanup sections

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

Merge request reports

Activity

Reviewer roulette

Before you set this MR to auto-merge

E2E Test Result Summary