Skip to content

Handle date range params in CA

Adam Hegyi requested to merge 13216-handle-date-range-params-in-ca into master

What does this MR do?

Related issue: #13216 (closed)

This MR introduces two additional params to cycle analytics (private) API: created_after and created_before.

There is a pending feature on the frontend side to allow users to pick a date range (using a datepicker component). This change allows the FE to pass in a date range.

Note to the reviewer: There is a bigger rewrite going on the CA backend, however it will take a while, the query and the filtering will be rewritten from the ground up.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

The queries were changed a bit to handle less than equal condition for created_before parameter (if passed). Doesn't affect the overall query performance.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports