chore: enable logging of mail delivery errors in development
What does this MR do?
Originates from gitlab-development-kit!824 (comment 225023428)
The development Rails environment disables logging of ActionMailer delivery errors. With the introduction of SMIME signed emails we are also documenting how to send SMTP mails in development in gitlab-development-kit!824 (merged).
The current approach requires to modify a committed file, which is not so convenient. In the meantime, we see no reason why this should be disabled in development, which would solve that inconvenience.
In development by default letter_opener_web is used. This delivery method usually does not raise errors, cause for every mail it just writes a file to disk, there's not much that can go wrong with that (except when the directory is read-only, but then it's nice to get an error about it).
The development of this MR is sponsored by Siemens (/cc @bufferoverflow)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team