Skip to content

Deduplicate vulnerability findings only based on signatures that belong to the same algorithm type from highest to lowest priority

What does this MR do and why?

At the moment we are deduplicating too many vulnerabilities leading to FNs (Rails Backend: Vulnerability fingerprints are c... (#470170 - closed) • Julian Thome • 17.11 • On track).

Changes the vulnerability comparison logic to include the algorithm type. In addition we also fix the comparison order -- they should always be compared from highest priority to lowest priority.

If we do not find a match for scope_offset_compressed, we fall back to scope_offset and so forth.

This MR fixes the following issues:

  1. Rails Backend: Vulnerability fingerprints are c... (#470170 - closed) • Julian Thome • 17.11 • On track
  2. https://gitlab.com/gitlab-org/gitlab/-/issues/512337+s

References

Understanding the Vulnerability Deduplication P... (&14805 - closed) • Julian Thome • On track

This MR includes a new feature flag; the corresponding roll-out issue is [Feature flag] Enable vulnerability_signatures_... (#525071 - closed) • Julian Thome • 17.11 • On track.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Julian Thome

Merge request reports

Loading