Fix `pngquant` script by requiring logger
What does this MR do and why?
Upstream bug in Rails causes bin/pngquant commands to fail in some setups.
Example output
/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:12:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
Logger::Severity.constants.each do |severity|
^^^^^^^^^^
from /home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>'
from /home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:8:in `<top (required)>'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from /home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/activesupport-7.0.8.7/lib/active_support/logger_silence.rb:5:in `<top (required)>'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from /home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/activesupport-7.0.8.7/lib/active_support/logger.rb:3:in `<top (required)>'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from /home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/activesupport-7.0.8.7/lib/active_support.rb:29:in `<top (required)>'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from /home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/gems/3.2.0/gems/railties-7.0.8.7/lib/rails.rb:7:in `<top (required)>'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:141:in `require'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:141:in `rescue in require'
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:135:in `require'
from bin/pngquant:4:in `<main>'
<internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- rails (LoadError)
from <internal:/home/marcin/.asdf/installs/ruby/3.2.4/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
from bin/pngquant:4:in `<main>'
Changelog: other
References
- https://docs.gitlab.com/ee/development/documentation/styleguide/#compress-images
- https://github.com/rails/rails/issues/54260
- Slack thread (internal, 90 days retention)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Marcin Sedlak-Jakubowski