Upgrade `gitlab-styles` to 13.1.0
What does this MR do and why?
Upgrade to gitlab-styles 13.1.0. See gitlab-org/ruby/gems/gitlab-styles!253 (merged).
Checklist
-
Verify upcoming release of gitlab-styles👉 10492c87-
Point to "Release" MR of gitlab-stylesinGemfile- For example,
gem 'gitlab-styles', '~> 9.1.0', require: false, git: 'https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles.git', ref: 'ddieulivol-upgrade_to_9.1.0' # rubocop:disable Cop/GemFetcher
- For example,
-
Update bundler's checksum file via bundle install && bundle exec bundler-checksum init -
Update Gemfile.nextviabundle install --gemfile Gemfile.next && cp Gemfile.lock Gemfile.next.lock && BUNDLE_GEMFILE=Gemfile.next bundle lock && BUNDLE_GEMFILE=Gemfile.next bundle exec bundler-checksum init -
rubocopjob👉 Got130 offenses detected, 127 offenses autocorrectablein 1m26s. See the "raw_job_output.log" section below.-
Inspect any warnings/errors -
(Optional) Generate TODOs for pending offenses -
Put 🆕 cop rules (or if configuration is changed) in "grace period". See docs.👉 3d57dc20 -
(Optional) Remove any offenses for disabled cops -
Use grep --extended-regexp -o ":[0-9]+:[0-9]+: [[:alnum:]]: \[[^[:space:]]+\] ([[:alnum:]/]+)" raw_job_output.log | awk '{print $4}' | sort | uniq -cto get a list of cop rules with offenses. Whereraw_job_output.logis the raw output of therubocopjob👇 31 Layout/EmptyLinesAroundMethodBody 10 Layout/TrailingWhitespace 72 Style/EndlessMethod 14 Style/SuperArguments
-
-
(Optional) Autocorrect offenses (only if the changeset is small) -
Compare the total runtime of rubocop --parallelscan with previous runs👉 1m28s
-
-
Make sure CI passes and does not have "silenced offenses" 💚 -
Don't merge this MR yet! -
Wait for gitlab-stylesto be released
-
-
Upgrade released version of gitlab-styles-
Make sure release is complete 👉 gitlab-org/ruby/gems/gitlab-styles!253 (comment 2339854763) -
Rephrase the title and MR description to match final upgrade -
Point to released version in Gemfile👉 612a5da5-
gem 'gitlab-styles', '~> 13.1.0', require: false -
Update bundler's checksum file via bundle install && bundle exec bundler-checksum init -
Update Gemfile.nextviabundle install --gemfile Gemfile.next && cp Gemfile.lock Gemfile.next.lock && BUNDLE_GEMFILE=Gemfile.next bundle lock && BUNDLE_GEMFILE=Gemfile.next bundle exec bundler-checksum init
-
-
(Optional) Regenerate TODOs for new/changed cop rules 👉 7c572082 -
Make sure CI passes and does not have "silenced offenses" 💚 -
Let the MR being reviewed again and merged -
(Optional) Refine this MR template.
-
raw_job_output.log
or
Offenses:
app/components/pajamas/toggle_component.rb:22:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
app/models/audit_event.rb:90:5: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(options).tap do |json|
^^^^^^^^^^^^^^
app/models/concerns/audit_events/common_model.rb:98:7: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(options).tap do |json|
^^^^^^^^^^^^^^
app/models/concerns/ci/contextable.rb:25:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
app/models/concerns/cross_database_modification.rb:82:7: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when all positional and keyword arguments are forwarded.
super(**options) do
^^^^^^^^^^^^^^^^
app/models/concerns/enum_inheritance.rb:46:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def inheritance_column_to_class_map = {}.freeze
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/group.rb:675:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
app/models/issue.rb:654:5: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(options).tap do |json|
^^^^^^^^^^^^^^
app/models/label.rb:248:5: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(options).tap do |json|
^^^^^^^^^^^^^^
app/models/list.rb:34:5: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(options).tap do |json|
^^^^^^^^^^^^^^
app/models/pages/project_settings.rb:9:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def url = url_builder.pages_url
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/pages/project_settings.rb:11:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def deployments = project.pages_deployments.active
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/pages/project_settings.rb:13:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def unique_domain_enabled? = project.project_setting.pages_unique_domain_enabled?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/pages/project_settings.rb:15:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def force_https? = project.pages_https_only?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/pages/project_settings.rb:17:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def pages_primary_domain = project.project_setting.pages_primary_domain
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/project_feature.rb:167:5: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(value).tap do
^^^^^^^^^^^^
app/models/repository.rb:947:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
app/models/repository.rb:965:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
app/services/members/destroy_service.rb:15:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
config/initializers/database_config.rb:13:5: W: Lint/Void: Constant Geo::TrackingBase used in void context.
Geo::TrackingBase
^^^^^^^^^^^^^^^^^
config/puma.rb:55:121: C: Layout/LineLength: Line is too long. [122/120]
require_relative "/Users/ychou/choznerol/contrib/gitlab/gitlab-development-kit/gitlab/lib/gitlab/cluster/lifecycle_events"
^^
config/puma.rb:97:121: C: Layout/LineLength: Line is too long. [125/120]
require_relative "/Users/ychou/choznerol/contrib/gitlab/gitlab-development-kit/gitlab/lib/gitlab/puma_logging/json_formatter"
^^^^^
ee/app/controllers/groups/security/compliance_dashboard/frameworks_controller.rb:44:9: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def framework = ComplianceManagement::Framework.find(params.permit(:id)[:id])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/helpers/ee/users_helper.rb:28:7: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(user).tap do |badges|
^^^^^^^^^^^
ee/app/models/compliance_management/framework.rb:56:5: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def filename = "compliance-framework-#{name.parameterize}-#{id}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/models/software_license.rb:44:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
ee/app/services/compliance_management/frameworks/json_export_service.rb:28:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def allowed? = Ability.allowed?(user, :read_compliance_dashboard, group)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/compliance_management/frameworks/json_export_service.rb:29:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def success = ServiceResponse.success(payload:)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/compliance_management/frameworks/json_export_service.rb:30:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def error = ServiceResponse.error(message: _('Failed to export framework'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/ee/protected_branches/create_service.rb:12:9: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(skip_authorization: skip_authorization).tap do |protected_branch_service|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/ee/protected_branches/destroy_service.rb:13:9: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(protected_branch).tap do |protected_branch_service|
^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/ee/users/destroy_service.rb:10:18: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
result = super(user, options) do |delete_user|
^^^^^^^^^^^^^^^^^^^^
ee/app/services/sbom/ingestion/vulnerability_data.rb:105:9: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def initialize(data) = @data = data || {}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/sbom/ingestion/vulnerability_data.rb:106:9: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def count = @data[:vulnerability_count] || 0
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/sbom/ingestion/vulnerability_data.rb:107:9: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def highest_severity = @data[:highest_severity]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/app/services/sbom/ingestion/vulnerability_data.rb:108:9: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def vulnerability_ids = @data[:vulnerability_ids] || []
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/lib/gitlab/elastic/helper.rb:30:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
ee/lib/remote_development/workspace_operations/reconcile/output/desired_config_generator.rb:124:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
ee/spec/support/helpers/identity_verification_helpers.rb:11:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb:989:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/api/helpers/packages_helpers.rb:55:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/backup/tasks/artifacts.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('artifacts')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/artifacts.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'artifacts.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/builds.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('builds')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/builds.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'builds.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/ci_secure_files.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('ci secure files')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/ci_secure_files.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'ci_secure_files.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/database.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('database')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/database.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'db'
^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/database.rb:12:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def cleanup_path = 'db'
^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/external_diffs.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('external diffs')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/external_diffs.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'external_diffs.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/lfs.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('lfs objects')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/lfs.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'lfs.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/packages.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('packages')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/packages.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'packages.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/pages.rb:12:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('pages')
^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/pages.rb:14:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'pages.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/registry.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def enabled = Gitlab.config.registry.enabled
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/registry.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('container registry images')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/registry.rb:12:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'registry.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/repositories.rb:16:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('repositories')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/repositories.rb:18:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'repositories'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/repositories.rb:20:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_optional = true
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:35:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def id = self.class.id
^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:49:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def cleanup_path = destination_path
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:52:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_optional = false
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:55:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def enabled = true
^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:57:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def enabled? = enabled
^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:60:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def pre_restore_warning = nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/task.rb:63:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def post_restore_warning = nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/terraform_state.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('terraform states')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/terraform_state.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'terraform_state.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/uploads.rb:8:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def human_name = _('uploads')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/backup/tasks/uploads.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def destination_path = 'uploads.tar.gz'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/background_migration/batched_migration_job.rb:82:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/ci/config/entry/product/matrix.rb:29:15: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(deps) do
^^^^^^^^^^^
lib/gitlab/ci/project_config.rb:30:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/cross_project_access.rb:26:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/data_builder/push.rb:102:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/database/migrations/constraints_helpers.rb:257:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/database/partitioning/list/convert_table.rb:19:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb:463:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/database_warnings.rb:15:77: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ ██ █████ ██████ ███ ██ ██ ███ ██ ██████
^
lib/gitlab/database_warnings.rb:16:72: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ ██ ██ ██ ██ ██ ████ ██ ██ ████ ██ ██
^^^^^^
lib/gitlab/database_warnings.rb:17:78: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ █ ██ ███████ ██████ ██ ██ ██ ██ ██ ██ ██ ██ ███
^
lib/gitlab/database_warnings.rb:18:78: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ ███ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██
^
lib/gitlab/database_warnings.rb:19:77: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
███ ███ ██ ██ ██ ██ ██ ████ ██ ██ ████ ██████
^^
lib/gitlab/database_warnings.rb:42:75: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ ██ █████ ██████ ███ ██ ██ ███ ██ ██████
^
lib/gitlab/database_warnings.rb:43:70: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ ██ ██ ██ ██ ██ ████ ██ ██ ████ ██ ██
^^^^^^
lib/gitlab/database_warnings.rb:44:76: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ █ ██ ███████ ██████ ██ ██ ██ ██ ██ ██ ██ ██ ███
^
lib/gitlab/database_warnings.rb:45:76: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
██ ███ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██
^
lib/gitlab/database_warnings.rb:46:75: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
███ ███ ██ ██ ██ ██ ██ ████ ██ ██ ████ ██████
^^
lib/gitlab/diff/file.rb:36:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/diff/inline_diff_markdown_marker.rb:12:9: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(line_inline_diffs) do |text, left:, right:, mode:|
^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/diff/inline_diff_marker.rb:11:9: C: [Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
super(line_inline_diffs) do |text, left:, right:, mode:|
^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/fp/settings/default_settings_parser.rb:64:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/git/repository.rb:1026:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/gitaly_client/operation_service.rb:265:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/gitaly_client/operation_service.rb:612:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/import/import_failure_service.rb:35:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/memory/upload_and_cleanup_reports.rb:13:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
lib/gitlab/pages/deployment_validations.rb:122:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def max_size_from_settings = Gitlab::CurrentSettings.max_pages_size.megabytes
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/pages/deployment_validations.rb:124:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def path_prefix = build.pages&.fetch(:path_prefix, '')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/pages/deployment_validations.rb:127:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def sha = build.sha
^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/design_management_repository.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def name = :design
^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/design_management_repository.rb:13:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def suffix = :design
^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/design_management_repository.rb:16:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def access_checker_class = ::Gitlab::GitAccessDesign
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/design_management_repository.rb:19:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def guest_read_ability = :download_code
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/design_management_repository.rb:22:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def container_class = DesignManagement::Repository
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/project_repository.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def name = :project
^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/project_repository.rb:13:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def access_checker_class = Gitlab::GitAccessProject
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/project_repository.rb:16:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def guest_read_ability = :download_code
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/project_repository.rb:19:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def container_class = Project
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/repo_type.rb:18:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def suffix = nil
^^^^^^^^^^^^^^^^
lib/gitlab/repositories/snippet_repository.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def name = :snippet
^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/snippet_repository.rb:13:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def access_checker_class = Gitlab::GitAccessSnippet
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/snippet_repository.rb:16:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def guest_read_ability = :read_snippet
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/snippet_repository.rb:19:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def container_class = Snippet
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/wiki_repository.rb:10:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def name = :wiki
^^^^^^^^^^^^^^^^
lib/gitlab/repositories/wiki_repository.rb:13:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def suffix = :wiki
^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/wiki_repository.rb:16:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def access_checker_class = Gitlab::GitAccessWiki
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/wiki_repository.rb:19:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def guest_read_ability = :download_wiki_code
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/repositories/wiki_repository.rb:22:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def container_class = ProjectWiki
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/gitlab/usage_data.rb:146:7: C: [Correctable] Style/EndlessMethod: Avoid endless method definitions.
def features_usage_data = {}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/gitlab/database/migrations/test_batched_background_runner_spec.rb:18:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
spec/lib/gitlab/popen/runner_spec.rb:123:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
spec/support/helpers/workhorse_lfs_helpers.rb:9:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
spec/support/matchers/invoke_rop_steps.rb:113:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
tooling/lib/tooling/find_changes.rb:24:1: C: [Correctable] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
41561 files inspected, 130 offenses detected, 127 offenses autocorrectableMR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
After merge
-
Notify team members of the upgrade by creating an announcement in relevant Slack channels ( #backendand#development) and Engineering Week In Review (EWIR).
Edited by Peter Leitzen