Skip to content

Outside Sidekiq, Gitaly long timeout = default timeout

Jacob Vosmaer requested to merge jv-gitaly-long-timeout into master

What does this MR do?

Hopefully fixes #32754 (closed)

Alternative approach to !17820 (closed).

The problem is that while setting up database seeds in development, we sometimes hit client side Gitaly timeouts. Possibly related to !16926 (merged).

There already is a mechanism around the database seeds that sets the Gitaly "default timeout" to 0, meaning there will be no timeout. Because of !16926 (merged) that wrapper stopped applying to some Gitaly calls. This change brings back that behavior.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jacob Vosmaer

Merge request reports