Skip to content

Add pipeline preparing status icons

Jacques Erasmus requested to merge update-preparing-stage-icon into master

This updates the preparing stage icons with new icons.

Issue: #27188 (closed)

Icon states

Favicon

Screenshot_2019-10-03_at_08.24.57


Pipeline header

Screenshot_2019-10-03_at_08.24.38


Pipeline info

Screenshot_2019-10-03_at_08.23.22


Pipeline table

Screenshot_2019-10-03_at_08.23.44

Testing

Note: I've bumped the package version for out @gitab/svgs dependency so you'll have to run yarn install to see the updated icons locally.

To test the icons, either set up the appropriate Kubernetes cluster or temporarily change the db values in your local environment:

  1. Open a terminal
  2. bundle exec rails console
  3. pipeline = Ci::Pipeline.find_by id: <pipeline-id>, project_id: <project-id>
    • <pipeline-id> is the id of the pipeline you intend to use for testing (id in url).
    • <project-id> can be found in the header section on the project details page.
  4. pipeline.update!(status:'preparing')
  5. You might need to hard refresh your browser after making these changes (hold down Shift and click the Reload button)

TODO

  • Add screenshots
  • Add status_preparing_borderless.svg to gitlab-svgs gitlab-svgs#44 (closed)
  • Add favicons to images/ci_favicons
  • Add/update tests

Does this MR meet the acceptance criteria?

Conformity

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading