Skip to content

Change security harness to rely on overcommit

Giorgenes Gelatti requested to merge overcommit-security-harness into master

What does this MR do?

Security harness relies on custom pre-push git hooks which conflicts with overcommit.

Overcommit is a much better tool for adding custom checks on git commands and can be used for many other checks. The existing security harness prevents the use of overcommit.

This MR proposes dropping the custom hook and relying on overcommit instead.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Giorgenes Gelatti

Merge request reports