Update to use `gl-button` instead of `gl-icon` in `visibility-icon`

What does this MR do and why?

As @psjakubowska mentioned here, the tooltip attached to the icon makes the SVG focusable. This MR resolves this by wrapping gl-icon with gl-button. This also follows the Pajamas guideline for icon with tooltip.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

• https://gitlab.com/gitlab-org/gitlab/-/issues/511885#note_2313430800

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

	Before	After
projects table on edit compliance framework page
projects list on group page

How to set up and validate locally

this component is being used twice in app:

1. Select Groups > Click on any of a group
2. In a project, Select Secure > Compliance Center
   1. Create a compliance framework
   2. Apply a compliance framework to projects in a group
   3. Edit compliance framework
   4. Expand project section

✅ Confirmed the fix with Voiceover

Resolves #511885