Introduce duo_chat_drop_redis_storage feature flag to drop redis call
NOTE: This MR is on top of Clean up duo_chat_storage_postgresql feature flags (!178985 - merged).
What does this MR do and why?
This MR introduces duo_chat_drop_redis_storage
feature flag to drop the redis call. The feature flag rollout issue is [Feature flag] Rollout of `duo_chat_drop_redis_... (#514898).
Related Remove Gitlab::Llm::ChatStorage::Redis storage ... (#501149) and [Feature flag] Rollout of `duo_chat_storage_pos... (#506874 - closed)
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @shinya.maeda
added pipelinetier-1 label
mentioned in merge request !178985 (merged)
added backend feature flag groupduo chat labels
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
added Category:Duo Chat devopsai-powered sectiondata-science labels
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @emeraldjayde
(UTC+0, 9 hours behind author)
@ahuntsman
(UTC-6, 15 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****changed milestone to %17.9
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@shinya.maeda
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
@evakadlecova Would you mind reviewing as backend reviewer? Please pass it to @lulalala if it looks good.
This is the feature flag for resolving the false-positive incident 2025-01-23: All traffic dropped to redis-cluste... (gitlab-com/gl-infra/production#19161 - closed).
added typefeature label
added typemaintenance label and removed typefeature label
requested review from @evakadlecova
mentioned in merge request !178710 (merged)
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
- Resolved by Mark Chao
@shinya.maeda The code looks good! I left a couple of suggestions for the specs. Additionally, I noticed that the changes to the
clear!
method are not tested, so it might be worth considering adding a test for that as well.
added 1603 commits
-
cc9def5e...b38829cc - 1600 commits from branch
master
- fd5d584a - Introduce feature flag to drop redis call
- a46c32e8 - Apply 1 suggestion(s) to 1 file(s)
- a0dcfa0c - Apply 2 suggestion(s) to 1 file(s)
Toggle commit list-
cc9def5e...b38829cc - 1600 commits from branch
@shinya.maeda Looks good!
@lulalala Can you please do the maintainer review?
requested review from @lulalala
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a0dcfa0cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 164 | 0 | 16 | 0 | 180 | ✅ | | Package | 48 | 0 | 28 | 0 | 76 | ✅ | | Fulfillment | 4 | 0 | 14 | 0 | 18 | ✅ | | Monitor | 16 | 0 | 24 | 0 | 40 | ✅ | | Create | 270 | 0 | 46 | 0 | 316 | ✅ | | Verify | 104 | 0 | 40 | 2 | 144 | ✅ | | Ai-powered | 0 | 0 | 4 | 0 | 4 | ➖ | | Manage | 2 | 0 | 18 | 0 | 20 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Govern | 158 | 0 | 26 | 0 | 184 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 66 | 0 | 20 | 0 | 86 | ✅ | | Release | 10 | 0 | 2 | 0 | 12 | ✅ | | Secure | 8 | 0 | 6 | 0 | 14 | ✅ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 854 | 0 | 256 | 2 | 1110 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for a0dcfa0cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 53 | 0 | 19 | 0 | 72 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 140 | 0 | 22 | 0 | 162 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 445 | 0 | 126 | 0 | 571 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
added this merge request to the merge train at position 2
mentioned in commit fe1497a5
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label