Skip to content
Snippets Groups Projects

Introduce duo_chat_drop_redis_storage feature flag to drop redis call

Merged Shinya Maeda requested to merge introduce-feature-flag-to-drop-redis-call into master
All threads resolved!

NOTE: This MR is on top of Clean up duo_chat_storage_postgresql feature flags (!178985 - merged).

What does this MR do and why?

This MR introduces duo_chat_drop_redis_storage feature flag to drop the redis call. The feature flag rollout issue is [Feature flag] Rollout of `duo_chat_drop_redis_... (#514898).

Related Remove Gitlab::Llm::ChatStorage::Redis storage ... (#501149) and [Feature flag] Rollout of `duo_chat_storage_pos... (#506874 - closed)

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Shinya Maeda

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @emeraldjayde profile link current availability (UTC+0, 9 hours behind author) @ahuntsman profile link current availability (UTC-6, 15 hours behind author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by ****
  • Shinya Maeda changed milestone to %17.9

    changed milestone to %17.9

  • Shinya Maeda added 1 commit

    added 1 commit

    • 63e7a550 - Introduce feature flag to drop redis call

    Compare with previous version

  • Shinya Maeda added 1 commit

    added 1 commit

    • 93d630a7 - Introduce feature flag to drop redis call

    Compare with previous version

  • Shinya Maeda added 1 commit

    added 1 commit

    • 184d4527 - Introduce feature flag to drop redis call

    Compare with previous version

  • Author Maintainer

    @evakadlecova Would you mind reviewing as backend reviewer? Please pass it to @lulalala if it looks good.

    This is the feature flag for resolving the false-positive incident 2025-01-23: All traffic dropped to redis-cluste... (gitlab-com/gl-infra/production#19161 - closed).

  • Shinya Maeda changed the description

    changed the description

  • Shinya Maeda added typemaintenance label and removed typefeature label

    added typemaintenance label and removed typefeature label

  • Shinya Maeda requested review from @evakadlecova

    requested review from @evakadlecova

  • Eva Kadlecová mentioned in merge request !178710 (merged)

    mentioned in merge request !178710 (merged)

  • Shinya Maeda added 1 commit

    added 1 commit

    • 367349dd - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Shinya Maeda added 1 commit

    added 1 commit

    • cc9def5e - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Shinya Maeda added 1603 commits

    added 1603 commits

    Compare with previous version

  • Shinya Maeda resolved all threads

    resolved all threads

  • @shinya.maeda Looks good!

    @lulalala Can you please do the maintainer review?

  • Eva Kadlecová requested review from @lulalala

    requested review from @lulalala

  • Eva Kadlecová approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for a0dcfa0c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 164    | 0      | 16      | 0     | 180   | ✅     |
    | Package     | 48     | 0      | 28      | 0     | 76    | ✅     |
    | Fulfillment | 4      | 0      | 14      | 0     | 18    | ✅     |
    | Monitor     | 16     | 0      | 24      | 0     | 40    | ✅     |
    | Create      | 270    | 0      | 46      | 0     | 316   | ✅     |
    | Verify      | 104    | 0      | 40      | 2     | 144   | ✅     |
    | Ai-powered  | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Manage      | 2      | 0      | 18      | 0     | 20    | ✅     |
    | Configure   | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Govern      | 158    | 0      | 26      | 0     | 184   | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 66     | 0      | 20      | 0     | 86    | ✅     |
    | Release     | 10     | 0      | 2       | 0     | 12    | ✅     |
    | Secure      | 8      | 0      | 6       | 0     | 14    | ✅     |
    | ModelOps    | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Growth      | 0      | 0      | 4       | 0     | 4     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 854    | 0      | 256     | 2     | 1110  | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for a0dcfa0c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 53     | 0      | 19      | 0     | 72    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Create      | 140    | 0      | 22      | 0     | 162   | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 445    | 0      | 126     | 0     | 571   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • Mark Chao approved this merge request

    approved this merge request

  • LGTM!

  • Mark Chao resolved all threads

    resolved all threads

  • Mark Chao enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Mark Chao added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • merged

  • Mark Chao mentioned in commit fe1497a5

    mentioned in commit fe1497a5

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading