Skip to content

Don't execute webhooks/services when above limit

Patrick Bajao requested to merge 31009-limit-project-hooks-services into master

What does this MR do?

If a single push has a number of changes over the threshold (push_event_hooks_limit setting, 3 by default), the related project webhooks and services won't be executed.

This way, in an event where bulk changes are pushed, the system won't be overloaded.

git_push_execute_all_project_hooks feature flag has been added so instance admins can choose to disable this behavior and still allow executing all project hooks regardless of number of changes.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#31009 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports