Scan diffs for changes commits via UI
What does this MR do and why?
Contributes to #491282 (closed)
Problem
Currently, diff scan is applied only to git pushes via ssh/https protocol, because there was no way to distiguishing between RPC actions that triggered the scan.
For example, we want to skip the check for merge commit creation but verify commits created via WebIDE.
#423992 (closed) introduces an option to pass additional context from Gitaly RPC endpoint to the checker code.
Solution
- Provide
enable_secrets_checkto selected RPC endpoints - Run diff scan for checks triggered by calls to these endpoints
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- SPP - Scan diffs for WebIDE changes (#491282 - closed)
- Update RPC to determine when a secrets check is... (#423992 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #423992 (closed)