Enable custom email parameter at service account creation

added pipelinetier-1 label

Thanks for your contribution to GitLab @lenaing!

If you need help, page a coach by clicking here or come say hi on Discord.
When you're ready, request a review by clicking here.
We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".

This message was generated automatically. Improve it or delete it.

added Community contribution workflowin dev labels

assigned to @lenaing

changed the description

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

added linked-issue label

requested review from @tachyons-gitlab

@tachyons-gitlab This MR is from co-create. We did not implement the same for group service accounts yet because of the note about enterprise users on the issue at #451032 (closed). We (GitLab) can address that in a follow-up.

	1 Message
	This merge request adds or changes documentation files and requires Technical Writing review. The review should happen before merge, but can be post-merge if the merge request is time sensitive.

Documentation review

The following files require a review from a technical writer:

doc/api/user_service_accounts.md (Link to current live version)

The review does not need to block merging this merge request. See the:

Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
The Technical Writer assigned for that stage and group.
Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@tyleramos` (UTC-5)	`@pedropombeiro` (UTC+1)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed milestone to %17.9

added featureaddition typefeature labels

added backend documentation labels

1 Warning

The master pipeline status page reported failures in

rspec unit pg14 35/44

If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

	1 Message
	This merge request adds or changes documentation files and requires Technical Writing review. The review should happen before merge, but can be post-merge if the merge request is time sensitive.

Documentation review

The following files require a review from a technical writer:

doc/api/user_service_accounts.md (Link to current live version)

The review does not need to block merging this merge request. See the:

Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
The Technical Writer assigned for that stage and group.
Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@tyleramos` (UTC-5)	`@pedropombeiro` (UTC+1)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Generated by gitlab_quality-test_tooling.

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#8916853899	`spec/features/admin/users/users_spec.rb#L179`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.01 s	< 50.13 s
#8933143755	`spec/features/admin/users/users_spec.rb#L179`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.42 s	< 50.13 s
#8934190461	`spec/features/admin/users/users_spec.rb#L179`	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	67.15 s	< 50.13 s

added rspec:slow test detected label

mentioned in issue gitlab-org/quality/triage-reports#21928 (closed)

@lenaing Could you also handle the the case of supplied email is already being present and update the API response accordingly when the service account creation fails ?

added 1 commit

c36438f5 - Fix service account creation documentation

Compare with previous version

added 1 commit

3cb7f3f4 - Add service account creation bad request test case

Compare with previous version

reset approvals from @dblessing by pushing to the branch

approved this merge request

enabled automatic add to merge train when checks pass

resolved all threads

started a merge train

removed this merge request from the merge train because the pipeline did not succeed. Learn more.

enabled automatic add to merge train when checks pass

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-cng: test report for 3cb7f3f4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Package     | 30     | 0      | 14      | 0     | 44    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Verify      | 51     | 0      | 19      | 0     | 70    | ✅     |
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
| Create      | 143    | 0      | 19      | 0     | 162   | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 447    | 0      | 122     | 0     | 569   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-gdk: test report for 3cb7f3f4

expand test summary

+-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Create | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan   | 3      | 0      | 0       | 0     | 3     | ✅     |
| Govern | 4      | 0      | 0       | 0     | 4     | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 11     | 0      | 0       | 0     | 11    | ✅     |
+--------+--------+--------+---------+-------+-------+--------+

started a merge train

merged

@lenaing, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

React with a or a on this comment to describe your experience.
Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

As a benefit of being a GitLab Community Contributor, you have access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.

Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. Improve it or delete it.