Follow up changes for !173949

Rushik Subbarequested to merge
srushik/follow_up_mr_173949 into master

What does this MR do and why?

Follow up changes for !173949 (merged)

  1. A case for when pipeline would appear nil in the CompareSecurityReportsService and would then be passed on to the Security::FindingsFinder was not handled properly in !173949 (comment 2305488730). This MR fixes that. The nil pipeline is passed on to the Findings::Finder and it now returns an empty Security::Finding ActiveRecord Relation.
  2. Improved specs - !173949 (comment 2305471218)

Relates to - #390185 (closed)

Edited by Rushik Subba

Merge request reports