Remove deprecated SAST jobs
What does this MR do and why?
Apply same changes as Remove deprecated SAST jobs (!178093 - merged) but to the stable CI templates.
I.e.:
-
bandit-sast
: removal overdue since 15.3 -
brakeman-sast
: removal overdue since 17.0 -
eslint-sast
: removal overdue since 15.3 -
flawfinder-sast
: removal overdue since 17.0 -
gosec-sast
: removal overdue since 15.2 -
mobsf-android-sast
: removal overdue since 17.0 -
mobsf-ios-sast
: removal overdue since 17.0 -
nodejs-scan-sast
: removal overdue since 17.0 -
phpcs-security-audit-sast
: removal overdue since 17.0 -
security-code-scan-sast
: removal overdue since 16.0
References
- SAST Deprecation: Analyzer consolidation and CI... (#352554 - closed)
- Static Analysis Analyzer consolidation in 16.0 (#390416 - closed)
- https://docs.gitlab.com/ee/update/deprecations.html#sast-analyzer-coverage-changing-in-gitlab-170
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #390416 (closed)
Merge request reports
Activity
changed milestone to %17.9
assigned to @thiagocsf
@thiagocsf thanks for adding the breaking change label!
This merge request introduces breaking changes. Learn more about breaking changes.
It's important to identify how the breaking change was introduced. To estimate the impact, try to assess the following:
- Are there existing users depending on this feature?
- Are self-managed customers affected?
- To verify and quantify usage, use Grafana or Kibana.
- If you're not sure about how to query the data, contact the infrastructure team on their Slack channel, #infrastructure-lounge
- Was sufficient time given to communicate the change?
- Changes in the permissions, the API schema, and the API response might affect existing 3rd party integrations.
- Reach out to the Support team or Technical Account Managers and ask about the possible impact of this change.
This message was generated automatically. Improve it or delete it.
- Are there existing users depending on this feature?
added pipelinetier-1 label
- Resolved by Thiago Figueiró
@mbenayoun, @marcel.amirault, this is the equivalent to !178093 (merged) but for the
stable
template.Since you reviewed the MR for
latest
, could you please review this one as well?
requested review from @marcel.amirault and @mbenayoun
added citemplates label
1 Warning ⚠️ This merge request adds or changes templates, please consider updating the corresponding
Gitlab Component.2 Messages 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
📖 This merge request adds or changes files that require a review from the CI/CD Templates maintainers. This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
- Prepare your MR for a CI/CD Template review according to the template development guide.
- Assign and
@
mention the CI/CD Template reviewer suggested by Reviewer Roulette.
The following files require a review from the CI/CD Templates maintainers:
lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml
Reviewer roulette
Category Reviewer Maintainer backend @srushik
(UTC+5.5, 5.5 hours behind author)
@jarka
(UTC+1, 10 hours behind author)
citemplates @seanarnold
(UTC+13, 2 hours ahead of author)
@hfyngvason
(UTC-5, 16 hours behind author)
devopsverify Reviewer review is optional for devopsverify @mbenayoun
(UTC+2, 9 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by ****requested review from @craigmsmith
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Hi
@marcel.amirault
👋 ,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. Improve it or delete it.
added Technical Writing label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for 234c45bfexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 79 | 0 | 13 | 0 | 92 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Verify | 52 | 0 | 20 | 1 | 72 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Create | 138 | 0 | 20 | 0 | 158 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 430 | 0 | 125 | 1 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
✅ test report for 234c45bfexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 143 | 0 | 19 | 0 | 162 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Verify | 53 | 0 | 19 | 0 | 72 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 448 | 0 | 123 | 0 | 571 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****reset approvals from @marcel.amirault by pushing to the branch
added backend label
- Resolved by Thiago Figueiró
reset approvals from @marcel.amirault by pushing to the branch
requested review from @bauerdominic
added 154 commits
-
2f36cb76...459bcd7b - 152 commits from branch
master
- 91637d06 - Remove deprecated SAST jobs
- 234c45bf - Apply 1 suggestion(s) to 1 file(s)
-
2f36cb76...459bcd7b - 152 commits from branch
reset approvals from @marcel.amirault by pushing to the branch
- Resolved by Thiago Figueiró
Looks good to me
requested review from @marcel.amirault
mentioned in merge request !177997 (merged)
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
- Resolved by Marcel Amirault
@marcel.amirault, been unlucky with pipeline flakes on this one. Do you mind setting merge again?
I've just triggered another pipeline that will hopefully be green by the time you see this.
started a merge train
mentioned in commit 7f8fcd3e
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#10160 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#10164 (closed)
added workflowstaging-canary label and removed workflowcomplete label