503371 / Rename Tool to Report Type + add feature flag vulnerability_report_type_scanner_filter
What does this MR do and why?
We are renaming Tool
to Report Type
on three different places:
- Vulnerability Report
- Vulnerability Single View
- Pipeline Scanning Security Results
Additionally, we are introducing the newly created feature flag vulnerability_report_type_scanner_filter
that will support our changes in #503371 (closed)
References
- Related issue: #503371 (closed)
- Feature flag rollout issue: #513546
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Reproduction Steps
- Check-out this branch, go to
http://gdk.test:3000/rails/features/
and enablevulnerability_report_type_scanner_filter
- Go to
http://gdk.test:3000/gitlab-org/security-reports/-/security/vulnerability_report
. The second to last column should be calledReport Type
- Go back to
go to
http://gdk.test:3000/rails/features/` and disablevulnerability_report_type_scanner_filter
. Go tohttp://gdk.test:3000/gitlab-org/security-reports/-/security/vulnerability_report
. The second to last column should now be calledTool
.
Enabled Feature Flag | Disabled Feature Flag |
---|---|
![]() |
![]() |
- Click on one of the vulnerabilities. With the feature flag enabled there should be a category shown in the vulnerability called
Report Type
. If the feature flag is disabled, it should be displayed asTool
.
Enabled Feature Flag | Disabled Feature Flag |
---|---|
![]() |
![]() |
- Go to one of the security pipelines. Just like for the Vulnerability Report overview, there should be a column with the header
Report Type
when the feature flag is enabled. That same header should be calledTool
when the feature flag is disabled.
Enabled Feature Flag | Disabled Feature Flag |
---|---|
![]() |
![]() |
Edited by Charlie Kroon