Skip to content

Extract Commit System Notes Service

What does this MR do?

One part of !16708 (closed)

I decided to split this up into smaller MRs by accepting the downside of a bit code duplication (SystemNotes::BaseService).

With this refactoring SystemNoteService will become some kind of facade for the several sub system note services.

Spec coverage should be given through https://gitlab.com/gitlab-org/gitlab/blob/master/spec%2Fservices%2Fsystem_note_service_spec.rb

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #17597 (closed)

Edited by Coung Ngo

Merge request reports