Skip to content

Resolve "DAST for the master branch"

Avielle Wolfe requested to merge 5503-dast-for-the-master-branch into master

Docs are in a separate MR: !18232 (merged)

What does this MR do?

This MR enables DAST on default branches.

Disabling DAST on the default branch

DAST on the default branch can be disabled by setting a DAST_DISABLED_FOR_DEFAULT_BRANCH environment variable to "true".

The review app

DAST will use its own review app on the default branch, and the existing review app on any other branch.

Screenshots

Before

This is what the pipeline looked like on a default branch before these changes

Screen_Shot_2019-10-15_at_1.11.28_PM

After

This is what the pipeline looks like on a default branch with DAST.

Screen_Shot_2019-10-15_at_1.17.41_PM

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

See #5503 (closed)

Edited by Lin Jen-Shin

Merge request reports