Remove feature flag for zoom quick actions on issues
What does this MR do?
This enables zoom quick actions by default. Previously they could be enabled or disabled via a feature flag added in this issue:
Development Process:
- Enabled the feature and checked that it was working on my dev stack
- Disabled the feature and confirmed that it was no longer working on my dev stack
- Removed feature flag
- Confirmed that commenting
/zoom <zoom_url>
on an issue was working on my dev stack again
WIP because the checklist is not complete.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Part of issue #32133 (closed)
Merge request reports
Activity
changed milestone to %12.4
1 Message 📖 Consider setting merge_request
to 17787 in changelogs/unreleased/32133-remove-feature-flag-for-zoom.yml. See the documentation.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Heinrich Lee Yu ( @engwan
)Jan Provaznik ( @jprovaznik
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖assigned to @engwan
- Resolved by Peter Leitzen
Thanks @allison.browne. I think we should also remove references to this flag in
doc/user/project/quick_actions.md
.Also, we'd need a changelog entry here since the feature will now be available.
unassigned @engwan
marked the checklist item Changelog entry as completed
marked the checklist item Documentation created/updated or follow-up review issue created as completed
marked the checklist item Style guides as completed
removed workflowready for development label
added workflowin review label
marked the checklist item Code review guidelines as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed