Skip to content
Snippets Groups Projects

WIP: Resolve "Remove feature flag `issue_zoom_integration`"

Closed Allison Browne requested to merge 32133-remove-zoom-command-feature-flag into master

What does this MR do?

Removes the feature flag that enables and disables the zoom integration added here: !16609 (diffs).

Opening this as WIP to make it easier to find the pipeline.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #32133 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Allison Browne changed milestone to %12.4

    changed milestone to %12.4

  • 1 Error
    🚫 c063b86d: The commit subject must start with a capital letter
    2 Warnings
    c063b86d: This commit’s subject line is acceptable, but please try to reduce it to 50 characters.
    This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.
    1 Message
    📖 CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.

    You can create one with:

    bin/changelog -m 17786 "Resolve "Remove feature flag `issue_zoom_integration`""

    If you want to create a changelog entry for GitLab EE, run the following instead:

    bin/changelog --ee -m 17786 "Resolve "Remove feature flag `issue_zoom_integration`""

    Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.

    Commit message standards

    One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

    Here is an example of a good commit message:

    Reject ruby interpolation in externalized strings
    
    When using ruby interpolation in externalized strings, they can't be
    detected. Which means they will never be presented to be translated.
    
    To mix variables into translations we need to use `sprintf`
    instead.
    
    Instead of:
    
        _("Hello #{subject}")
    
    Use:
    
        _("Hello %{subject}") % { subject: 'world' }

    This is an example of a bad commit message:

    updated README.md

    This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Brett Walker (@digitalmoksha) Stan Hu (@stanhu)

    Generated by 🚫 Danger

  • reopened

Please register or sign in to reply
Loading