Fix notes race condition when linking to specific note
requested to merge 30497-race-condition-in-discussions-json-request-could-lead-to-notes-showing-inconsistently-with-selected-notes-filter into master
What does this MR do?
This merge request fixes a race condition when linking to a specific note in an issue.
Before, there would sometimes be two requests for notes (discussions.json) when linking to a specific note. Now, there is only one request for notes whether linking to a specific note or not.
Screenshots
Before:
After:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo