Skip to content

Update artifact size authorization

Erick Bajao requested to merge eb-custom-max-artifacts-size into master

What does this MR do?

This is part of the work for #21688 (closed). This covers updating the authorization logic for artifacts size to now factor in the new project and namespace level max_artifacts_size setting.

This also adds a new helper method Project#closest_setting which fetches the closest non-nil value for a given setting name. This will be useful for other settings like max_pages_size.

A separate MR will be opened for implementing the form fields for these new settings.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Erick Bajao

Merge request reports