Skip to content

Chore: fix ml experiments show spec

Marina Mostirequested to merge
marina.mosti-512438-ml_experiments_show_spec into master

What does this MR do and why?

Make the ML experiments show spec pass for Vue 3 under Vue router 4

The deleted test throws a warning under Vue router 4:

[1] warn: [Vue Router warn]: Discarded invalid param(s) "pathMatch" when navigating. See https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2022-08-22 for more details.

Navigation to an invalid route via router.push is not valid and considered an antipattern. I understand that we want to have coverage on the redirect * route, but we'll have to trust for this one that Vue router is doing its job.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports