Skip to content

Allow users to be found by @username

Sean Arnold requested to merge allow-username-search-to-work-with-at-sign into master

What does this MR do?

This allows users to be found by queries that prefix their username with @. It simply strips the @ before querying.

As we reference users across Gitlab by their username presented in the @username format, it makes sense to be able to search them even with the @ prefix.

Personally I've will find this particularly useful when assigning Issues/MRs to other users as I have muscle memory of prefixing their name with @.

Note: the implementation also means that you can search a User's name with @. i.e @user name will match on a user with the name User Name.

Screenshots

Old Behaviour Screen_Shot_2019-09-26_at_9.38.29_PMScreen_Shot_2019-09-26_at_9.38.41_PM

New Behaviour Screen_Shot_2019-09-26_at_9.40.33_PM

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sean Arnold

Merge request reports