Add NOT NULL for sharding key on work_item_parent_links

changed milestone to %17.9

added Category:Organization backend devopstenant scale grouporganizations missed:17.5 missed:17.6 missed:17.7 sectioninfrastructure platforms typefeature workflowready for development labels

assigned to @smaglangit

mentioned in issue #493768

added pipelinetier-1 label

added database databasereview pending labels

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.

Reviewer roulette

Category	Reviewer	Maintainer
database	`@tachyons-gitlab` (UTC+5.5, 2.5 hours behind author)	`@krasio` (UTC+13, 5 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added Data WarehouseImpact Check label

added 510 commits

ec14dbd7...b3660f7c - 509 commits from branch master
8bf017db - Add NOT NULL constraint on work_item_parent_links.namespace_id

Compare with previous version

Database migrations (on the main database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint	Post deploy	5.7 s		+0.00 B
20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation	Post deploy	5.7 s		+0.00 B

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	0
0.1 seconds - 1 second	9
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint

* Type: Post deploy
* Duration: 5.7 s
* Database size change: +0.00 B

Calls

Total Time

Max Time

Mean Time

Rows

Query

1

5.9 ms

1

SELECT c.is_nullable
  FROM information_schema.columns c
  WHERE c.table_schema = $1 AND c.table_name = $2 AND c.column_name = $3

1

5.4 ms

0

ALTER TABLE work_item_parent_links ADD CONSTRAINT check_e9c0111985 CHECK ( namespace_id IS NOT NULL ) NOT VALID

2

0.0 ms

2

SELECT pg_backend_pid()

Histogram for AddWorkItemParentLinksNamespaceIdNotNullConstraint

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	0
0.1 seconds - 1 second	4
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation

* Type: Post deploy
* Duration: 5.7 s
* Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
1	0.1 ms	0.1 ms	0.1 ms	1	INSERT INTO "postgres_async_foreign_key_validations" ("created_at", "updated_at", "name", "table_name", "constraint_type") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
1	0.0 ms	0.0 ms	0.0 ms	0	SELECT "postgres_async_foreign_key_validations".* FROM "postgres_async_foreign_key_validations" WHERE "postgres_async_foreign_key_validations"."constraint_type" = $1 AND "postgres_async_foreign_key_validations"."name" = $2 AND "postgres_async_foreign_key_validations"."table_name" = $3 LIMIT $4
1	0.0 ms	0.0 ms	0.0 ms	0	SELECT $1 AS one FROM "postgres_async_foreign_key_validations" WHERE "postgres_async_foreign_key_validations"."name" = $2 AND "postgres_async_foreign_key_validations"."table_name" = $3 LIMIT $4
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for PrepareWorkItemParentLinksNamespaceIdNotNullValidation

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	0
0.1 seconds - 1 second	5
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Background Migration: BackfillSeatAssignmentsTable

Sampled 135 batches. Estimated Time to complete: 1 week, 3 hours, and 10 minutes

Interval: 120s
Max batch size: 0
Estimated seconds to complete: 616200s
Average batch time: 11.35s
Batch size: 10000
N. of batches sampled: 135
N. of failed batches: 0

Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.

Consider changing max_batch_size and interval if this estimate is unacceptable.

Calls	Total Time	Max Time	Mean Time	Rows	Query
1206	200932.2 ms	1227.0 ms	166.6 ms	413154	SELECT DISTINCT user_id, ( SELECT traversal_ids[$1] FROM namespaces WHERE id = members.member_namespace_id ) AS root_namespace_id FROM members WHERE id IN ( SELECT members.id FROM members WHERE members.id BETWEEN $2 AND $3 AND members.id >= $4 AND members.id < $5 AND members.user_id IS NOT NULL AND EXISTS ( SELECT $6 FROM namespaces WHERE namespaces.type = $7 AND namespaces.id = ( SELECT traversal_ids[$8] FROM namespaces WHERE id = members.member_namespace_id ) ) AND EXISTS ( SELECT $9 FROM users WHERE users.id = members.user_id ) )
135	20345.4 ms	1170.5 ms	150.7 ms	46632	SELECT DISTINCT user_id, ( SELECT traversal_ids[$1] FROM namespaces WHERE id = members.member_namespace_id ) AS root_namespace_id FROM members WHERE id IN ( SELECT members.id FROM members WHERE members.id BETWEEN $2 AND $3 AND members.id >= $4 AND members.user_id IS NOT NULL AND EXISTS ( SELECT $5 FROM namespaces WHERE namespaces.type = $6 AND namespaces.id = ( SELECT traversal_ids[$7] FROM namespaces WHERE id = members.member_namespace_id ) ) AND EXISTS ( SELECT $8 FROM users WHERE users.id = members.user_id ) )
1337	83288.4 ms	602.3 ms	62.3 ms	392031	INSERT INTO subscription_seat_assignments (namespace_id, user_id, created_at, updated_at) VALUES ($1, $2, $3, $4), ($5, $6, $7, $8), ($9, $10, $11, $12), ($13, $14, $15, $16), ($17, $18, $19, $20), ($21, $22, $23, $24), ($25, $26, $27, $28), ($29, $30, $31, $32), ($33, $34, $35, $36), ($37, $38, $39, $40), ($41, $42, $43, $44), ($45, $46, $47, $48), ($49, $50, $51, $52), ($53, $54, $55, $56), ($57, $58, $59, $60), ($61, $62, $63, $64), ($65, $66, $67, $68), ($69, $70, $71, $72), ($73, $74, $75, $76), ($77, $78, $79, $80), ($81, $82, $83, $84), ($85, $86, $87, $88), ($89, $90, $91, $92), ($93, $94, $95, $96), ($97, $98, $99, $100), ($101, $102, $103, $104), ($105, $106, $107, $108), ($109, $110, $111, $112), ($113, $114, $115, $116), ($117, $118, $119, $120), ($121, $122, $123, $124), ($125, $126, $127, $128), ($129, $130, $131, $132), ($133, $134, $135, $136), ($137, $138, $139, $140), ($141, $142, $143, $144), ($145, $146, $147, $148), ($149, $150, $151, $152), ($153, $154, $155, $156), ($157, $158, $159, $160), ($161, $162, $163, $164), ($165, $166, $167, $168), ($169, $170, $171, $172), ($173, $174, $175, $176), ($177, $178, $179, $180), ($181, $182, $183, $184), ($185, $186, $187, $188), ($189, $190, $191, $192), ($193, $194, $195, $196), ($197, $198, $199, $200), ($201, $202, $203, $204), ($205, $206, $207, $208), ($209, $210, $211, $212), ($213, $214, $215, $216), ($217, $218, $219, $220), ($221, $222, $223, $224), ($225, $226, $227, $228), ($229, $230, $231, $232), ($233, $234, $235, $236), ($237, $238, $239, $240), ($241, $242, $243, $244), ($245, $246, $247, $248), ($249, $250, $251, $252), ($253, $254, $255, $256), ($257, $258, $259, $260), ($261, $262, $263, $264), ($265, $266, $267, $268), ($269, $270, $271, $272), ($273, $274, $275, $276), ($277, $278, $279, $280), ($281, $282, $283, $284), ($285, $286, $287, $288), ($289, $290, $291, $292), ($293, $294, $295, $296), ($297, $298, $299, $300), ($301, $302, $303, $304), ($305, $306, $307, $308), ($309, $310, $311, $312), ($313, $314, $315, $316), ($317, $318, $319, $320), ($321, $322, $323, $324), ($325, $326, $327, $328), ($329, $330, $331, $332), ($333, $334, $335, $336), ($337, $338, $339, $340), ($341, $342, $343, $344), ($345, $346, $347, $348), ($349, $350, $351, $352), ($353, $354, $355, $356), ($357, $358, $359, $360), ($361, $362, $363, $364), ($365, $366, $367, $368), ($369, $370, $371, $372), ($373, $374, $375, $376), ($377, $378, $379, $380), ($381, $382, $383, $384), ($385, $386, $387, $388), ($389, $390, $391, $392), ($393, $394, $395, $396), ($397, $398, $399, $400), ($401, $402, $403, $404), ($405, $406, $407, $408), ($409, $410, $411, $412), ($413, $414, $415, $416), ($417, $418, $419, $420), ($421, $422, $423, $424), ($425, $426, $427, $428), ($429, $430, $431, $432), ($433, $434, $435, $436), ($437, $438, $439, $440), ($441, $442, $443, $444), ($445, $446, $447, $448), ($449, $450, $451, $452), ($453, $454, $455, $456), ($457, $458, $459, $460), ($461, $462, $463, $464), ($465, $466, $467, $468), ($469, $470, $471, $472), ($473, $474, $475, $476), ($477, $478, $479, $480), ($481, $482, $483, $484), ($485, $486, $487, $488), ($489, $490, $491, $492), ($493, $494, $495, $496), ($497, $498, $499, $500), ($501, $502, $503, $504), ($505, $506, $507, $508), ($509, $510, $511, $512), ($513, $514, $515, $516), ($517, $518, $519, $520), ($521, $522, $523, $524), ($525, $526, $527, $528), ($529, $530, $531, $532), ($533, $534, $535, $536), ($537, $538, $539, $540), ($541, $542, $543, $544), ($545, $546, $547, $548), ($549, $550, $551, $552), ($553, $554, $555, $556), ($557, $558, $559, $560), ($561, $562, $563, $564), ($565, $566, $567, $568), ($569, $570, $571, $572), ($573, $574, $575, $576), ($577, $578, $579, $580), ($581, $582, $583, $584), ($585, $586, $587, $588), ($589, $590, $591, $592), ($593, $594, $595, $596), ($597, $598, $599, $600), ($601, $602, $603, $604), ($605, $606, $607, $608), ($609, $610, $611, $612), ($613, $614, $615, $616), ($617, $618, $619, $620), ($621, $622, $623, $624), ($625, $626, $627, $628), ($629, $630, $631, $632), ($633, $634, $635, $636), ($637, $638, $639, $640), ($641, $642, $643, $644), ($645, $646, $647, $648), ($649, $650, $651, $652), ($653, $654, $655, $656), ($657, $658, $659, $660), ($661, $662, $663, $664), ($665, $666, $667, $668), ($669, $670, $671, $672), ($673, $674, $675, $676), ($677, $678, $679, $680), ($681, $682, $683, $684), ($685, $686, $687, $688), ($689, $690, $691, $692), ($693, $694, $695, $696), ($697, $698, $699, $700), ($701, $702, $703, $704), ($705, $706, $707, $708), ($709, $710, $711, $712), ($713, $714, $715, $716), ($717, $718, $719, $720), ($721, $722, $723, $724), ($725, $726, $727, $728), ($729, $730, $731, $732), ($733, $734, $735, $736), ($737, $738, $739, $740), ($741, $742, $743, $744), ($745, $746, $747, $748), ($749, $750, $751, $752), ($753, $754, $755, $756), ($757, $758, $759, $760), ($761, $762, $763, $764), ($765, $766, $767, $768), ($769, $770, $771, $772), ($773, $774, $775, $776), ($777, $778, $779, $780), ($781, $782, $783, $784), ($785, $786, $787, $788), ($789, $790, $791, $792), ($793, $794, $795, $796), ($797, $798, $799, $800), ($801, $802, $803, $804), ($805, $806, $807, $808), ($809, $810, $811, $812), ($813, $814, $815, $816), ($817, $818, $819, $820), ($821, $822, $823, $824), ($825, $826, $827, $828), ($829, $830, $831, $832), ($833, $834, $835, $836), ($837, $838, $839, $840), ($841, $842, $843, $844), ($845, $846, $847, $848), ($849, $850, $851, $852), ($853, $854, $855, $856), ($857, $858, $859, $860), ($861, $862, $863, $864), ($865, $866, $867, $868), ($869, $870, $871, $872), ($873, $874, $875, $876), ($877, $878, $879, $880), ($881, $882, $883, $884), ($885, $886, $887, $888), ($889, $890, $891, $892), ($893, $894, $895, $896), ($897, $898, $899, $900), ($901, $902, $903, $904), ($905, $906, $907, $908), ($909, $910, $911, $912), ($913, $914, $915, $916), ($917, $918, $919, $920), ($921, $922, $923, $924), ($925, $926, $927, $928), ($929, $930, $931, $932), ($933, $934, $935, $936), ($937, $938, $939, $940), ($941, $942, $943, $944), ($945, $946, $947, $948), ($949, $950, $951, $952), ($953, $954, $955, $956), ($957, $958, $959, $960), ($961, $962, $963, $964), ($965, $966, $967, $968), ($969, $970, $971, $972), ($973, $974, $975, $976), ($977, $978, $979, $980), ($981, $982, $983, $984), ($985, $986, $987, $988), ($989, $990, $991, $992), ($993, $994, $995, $996), ($997, $998, $999, $1000), ($1001, $1002, $1003, $1004), ($1005, $1006, $1007, $1008), ($1009, $1010, $1011, $1012), ($1013, $1014, $1015, $1016), ($1017, $1018, $1019, $1020), ($1021, $1022, $1023, $1024), ($1025, $1026, $1027, $1028), ($1029, $1030, $1031, $1032), ($1033, $1034, $1035, $1036), ($1037, $1038, $1039, $1040), ($1041, $1042, $1043, $1044), ($1045, $1046, $1047, $1048), ($1049, $1050, $1051, $1052), ($1053, $1054, $1055, $1056), ($1057, $1058, $1059, $1060), ($1061, $1062, $1063, $1064), ($1065, $1066, $1067, $1068), ($1069, $1070, $1071, $1072), ($1073, $1074, $1075, $1076), ($1077, $1078, $1079, $1080), ($1081, $1082, $1083, $1084), ($1085, $1086, $1087, $1088), ($1089, $1090, $1091, $1092), ($1093, $1094, $1095, $1096), ($1097, $1098, $1099, $1100), ($1101, $1102, $1103, $1104), ($1105, $1106, $1107, $1108), ($1109, $1110, $1111, $1112), ($1113, $1114, $1115, $1116), ($1117, $1118, $1119, $1120), ($1121, $1122, $1123, $1124), ($1125, $1126, $1127, $1128), ($1129, $1130, $1131, $1132), ($1133, $1134, $1135, $1136), ($1137, $1138, $1139, $1140), ($1141, $1142, $1143, $1144), ($1145, $1146, $1147, $1148), ($1149, $1150, $1151, $1152), ($1153, $1154, $1155, $1156), ($1157, $1158, $1159, $1160), ($1161, $1162, $1163, $1164), ($1165, $1166, $1167, $1168), ($1169, $1170, $1171, $1172), ($1173, $1174, $1175, $1176), ($1177, $1178, $1179, $1180), ($1181, $1182, $1183, $1184), ($1185, $1186, $1187, $1188), ($1189, $1190, $1191, $1192), ($1193, $1194, $1195, $1196), ($1197, $1198, $1199, $1200), ($1201, $1202, $1203, $1204), ($1205, $1206, $1207, $1208), ($1209, $1210, $1211, $1212), ($1213, $1214, $1215, $1216), ($1217, $1218, $1219, $1220), ($1221, $1222, $1223, $1224), ($1225, $1226, $1227, $1228), ($1229, $1230, $1231, $1232), ($1233, $1234, $1235, $1236), ($1237, $1238, $1239, $1240), ($1241, $1242, $1243, $1244), ($1245, $1246, $1247, $1248), ($1249, $1250, $1251, $1252), ($1253, $1254, $1255, $1256), ($1257, $1258, $1259, $1260), ($1261, $1262, $1263, $1264), ($1265, $1266, $1267, $1268), ($1269, $1270, $1271, $1272), ($1273, $1274, $1275, $1276), ($1277, $1278, $1279, $1280), ($1281, $1282, $1283, $1284), ($1285, $1286, $1287, $1288), ($1289, $1290, $1291, $1292), ($1293, $1294, $1295, $1296), ($1297, $1298, $1299, $1300), ($1301, $1302, $1303, $1304), ($1305, $1306, $1307, $1308), ($1309, $1310, $1311, $1312), ($1313, $1314, $1315, $1316), ($1317, $1318, $1319, $1320), ($1321, $1322, $1323, $1324), ($1325, $1326, $1327, $1328), ($1329, $1330, $1331, $1332), ($1333, $1334, $1335, $1336), ($1337, $1338, $1339, $1340), ($1341, $1342, $1343, $1344), ($1345, $1346, $1347, $1348), ($1349, $1350, $1351, $1352), ($1353, $1354, $1355, $1356), ($1357, $1358, $1359, $1360), ($1361, $1362, $1363, $1364), ($1365, $1366, $1367, $1368), ($1369, $1370, $1371, $1372), ($1373, $1374, $1375, $1376), ($1377, $1378, $1379, $1380), ($1381, $1382, $1383, $1384), ($1385, $1386, $1387, $1388), ($1389, $1390, $1391, $1392), ($1393, $1394, $1395, $1396), ($1397, $1398, $1399, $1400), ($1401, $1402, $1403, $1404), ($1405, $1406, $1407, $1408), ($1409, $1410, $1411, $1412), ($1413, $1414, $1415, $1416), ($1417, $1418, $1419, $1420), ($1421, $1422, $1423, $1424), ($1425, $1426, $1427, $1428), ($1429, $1430, $1431, $1432), ($1433, $1434, $1435, $1436), ($1437, $1438, $1439, $1440), ($1441, $1442, $1443, $1444), ($1445, $1446, $1447, $1448), ($1449, $1450, $1451, $1452), ($1453, $1454, $1455, $1456), ($1457, $1458, $1459, $1460), ($1461, $1462, $1463, $1464), ($1465, $1466, $1467, $1468), ($1469, $1470, $1471, $1472), ($1473, $1474, $1475, $1476), ($1477, $1478, $1479, $1480), ($1481, $1482, $1483, $1484), ($1485, $1486, $1487, $1488), ($1489, $1490, $1491, $1492), ($1493, $1494, $1495, $1496), ($1497, $1498, $1499, $1500), ($1501, $1502, $1503, $1504), ($1505, $1506, $1507, $1508), ($1509, $1510, $1511, $1512), ($1513, $1514, $1515, $1516), ($1517, $1518, $1519, $1520), ($1521, $1522, $1523, $1524), ($1525, $1526, $1527, $1528), ($1529, $1530, $1531, $1532), ($1533, $1534, $1535, $1536), ($1537, $1538, $1539, $1540), ($1541, $1542, $1543, $1544), ($1545, $1546, $1547, $1548), ($1549, $1550, $1551, $1552), ($1553, $1554, $1555, $1556), ($1557, $1558, $1559, $1560), ($1561, $1562, $1563, $1564), ($1565, $1566, $1567, $1568), ($1569, $1570, $1571, $1572), ($1573, $1574, $1575, $1576), ($1577, $1578, $1579, $1580), ($1581, $1582, $1583, $1584), ($1585, $1586, $1587, $1588), ($1589, $1590, $1591, $1592), ($1593, $1594, $1595, $1596), ($1597, $1598, $1599, $1600), ($1601, $1602, $1603, $1604), ($1605, $1606, $1607, $1608), ($1609, $1610, $1611, $1612), ($1613, $1614, $1615, $1616), ($1617, $1618, $1619, $1620), ($1621, $1622, $1623, $1624), ($1625, $1626, $1627, $1628), ($1629, $1630, $1631, $1632), ($1633, $1634, $1635, $1636), ($1637, $1638, $1639, $1640), ($1641, $1642, $1643, $1644), ($1645, $1646, $1647, $1648), ($1649, $1650, $1651, $1652), ($1653, $1654, $1655, $1656), ($1657, $1658, $1659, $1660), ($1661, $1662, $1663, $1664), ($1665, $1666, $1667, $1668), ($1669, $1670, $1671, $1672), ($1673, $1674, $1675, $1676), ($1677, $1678, $1679, $1680), ($1681, $1682, $1683, $1684), ($1685, $1686, $1687, $1688) ON CONFLICT (namespace_id, user_id) DO NOTHING RETURNING id
1341	1466.5 ms	14.7 ms	1.1 ms	67755	SELECT namespace_id AS root_namespace_id, user_id FROM subscription_seat_assignments WHERE (namespace_id, user_id) IN (VALUES ($1, $2), ($3, $4), ($5, $6), ($7, $8), ($9, $10), ($11, $12), ($13, $14), ($15, $16), ($17, $18), ($19, $20), ($21, $22), ($23, $24), ($25, $26), ($27, $28), ($29, $30), ($31, $32), ($33, $34), ($35, $36), ($37, $38), ($39, $40), ($41, $42), ($43, $44), ($45, $46), ($47, $48), ($49, $50), ($51, $52), ($53, $54), ($55, $56), ($57, $58), ($59, $60), ($61, $62), ($63, $64), ($65, $66), ($67, $68), ($69, $70), ($71, $72), ($73, $74), ($75, $76), ($77, $78), ($79, $80), ($81, $82), ($83, $84), ($85, $86), ($87, $88), ($89, $90), ($91, $92), ($93, $94), ($95, $96), ($97, $98), ($99, $100), ($101, $102), ($103, $104), ($105, $106), ($107, $108), ($109, $110), ($111, $112), ($113, $114), ($115, $116), ($117, $118), ($119, $120), ($121, $122), ($123, $124), ($125, $126), ($127, $128), ($129, $130), ($131, $132), ($133, $134), ($135, $136), ($137, $138), ($139, $140), ($141, $142), ($143, $144), ($145, $146), ($147, $148), ($149, $150), ($151, $152), ($153, $154), ($155, $156), ($157, $158), ($159, $160), ($161, $162), ($163, $164), ($165, $166), ($167, $168), ($169, $170), ($171, $172), ($173, $174), ($175, $176), ($177, $178), ($179, $180), ($181, $182), ($183, $184), ($185, $186), ($187, $188), ($189, $190), ($191, $192), ($193, $194), ($195, $196), ($197, $198), ($199, $200), ($201, $202), ($203, $204), ($205, $206), ($207, $208), ($209, $210), ($211, $212), ($213, $214), ($215, $216), ($217, $218), ($219, $220), ($221, $222), ($223, $224), ($225, $226), ($227, $228), ($229, $230), ($231, $232), ($233, $234), ($235, $236), ($237, $238), ($239, $240), ($241, $242), ($243, $244), ($245, $246), ($247, $248), ($249, $250), ($251, $252), ($253, $254), ($255, $256), ($257, $258), ($259, $260), ($261, $262), ($263, $264), ($265, $266), ($267, $268), ($269, $270), ($271, $272), ($273, $274), ($275, $276), ($277, $278), ($279, $280), ($281, $282), ($283, $284), ($285, $286), ($287, $288), ($289, $290), ($291, $292), ($293, $294), ($295, $296), ($297, $298), ($299, $300), ($301, $302), ($303, $304), ($305, $306), ($307, $308), ($309, $310), ($311, $312), ($313, $314), ($315, $316), ($317, $318), ($319, $320), ($321, $322), ($323, $324), ($325, $326), ($327, $328), ($329, $330), ($331, $332), ($333, $334), ($335, $336), ($337, $338), ($339, $340), ($341, $342), ($343, $344), ($345, $346), ($347, $348), ($349, $350), ($351, $352), ($353, $354), ($355, $356), ($357, $358), ($359, $360), ($361, $362), ($363, $364), ($365, $366), ($367, $368), ($369, $370), ($371, $372), ($373, $374), ($375, $376), ($377, $378), ($379, $380), ($381, $382), ($383, $384), ($385, $386), ($387, $388), ($389, $390), ($391, $392), ($393, $394), ($395, $396), ($397, $398), ($399, $400), ($401, $402), ($403, $404), ($405, $406), ($407, $408), ($409, $410), ($411, $412), ($413, $414), ($415, $416), ($417, $418), ($419, $420), ($421, $422), ($423, $424), ($425, $426), ($427, $428), ($429, $430), ($431, $432), ($433, $434), ($435, $436), ($437, $438), ($439, $440), ($441, $442), ($443, $444), ($445, $446), ($447, $448), ($449, $450), ($451, $452), ($453, $454), ($455, $456), ($457, $458), ($459, $460), ($461, $462), ($463, $464), ($465, $466), ($467, $468), ($469, $470), ($471, $472), ($473, $474), ($475, $476), ($477, $478), ($479, $480), ($481, $482), ($483, $484), ($485, $486), ($487, $488), ($489, $490), ($491, $492), ($493, $494), ($495, $496), ($497, $498), ($499, $500), ($501, $502), ($503, $504), ($505, $506), ($507, $508), ($509, $510), ($511, $512), ($513, $514), ($515, $516), ($517, $518), ($519, $520), ($521, $522), ($523, $524), ($525, $526), ($527, $528), ($529, $530), ($531, $532), ($533, $534), ($535, $536), ($537, $538), ($539, $540), ($541, $542), ($543, $544), ($545, $546), ($547, $548), ($549, $550), ($551, $552), ($553, $554), ($555, $556), ($557, $558), ($559, $560), ($561, $562), ($563, $564), ($565, $566), ($567, $568), ($569, $570), ($571, $572), ($573, $574), ($575, $576), ($577, $578), ($579, $580), ($581, $582), ($583, $584), ($585, $586), ($587, $588), ($589, $590), ($591, $592), ($593, $594), ($595, $596), ($597, $598), ($599, $600), ($601, $602), ($603, $604), ($605, $606), ($607, $608), ($609, $610), ($611, $612), ($613, $614), ($615, $616), ($617, $618), ($619, $620), ($621, $622), ($623, $624), ($625, $626), ($627, $628), ($629, $630), ($631, $632), ($633, $634), ($635, $636), ($637, $638), ($639, $640), ($641, $642), ($643, $644), ($645, $646), ($647, $648), ($649, $650), ($651, $652), ($653, $654), ($655, $656), ($657, $658), ($659, $660), ($661, $662), ($663, $664), ($665, $666), ($667, $668), ($669, $670), ($671, $672), ($673, $674), ($675, $676), ($677, $678), ($679, $680), ($681, $682), ($683, $684), ($685, $686), ($687, $688), ($689, $690), ($691, $692), ($693, $694), ($695, $696), ($697, $698), ($699, $700), ($701, $702), ($703, $704), ($705, $706), ($707, $708), ($709, $710), ($711, $712), ($713, $714), ($715, $716), ($717, $718), ($719, $720), ($721, $722), ($723, $724), ($725, $726), ($727, $728), ($729, $730), ($731, $732), ($733, $734), ($735, $736), ($737, $738), ($739, $740), ($741, $742), ($743, $744), ($745, $746), ($747, $748), ($749, $750), ($751, $752), ($753, $754), ($755, $756), ($757, $758), ($759, $760), ($761, $762), ($763, $764), ($765, $766), ($767, $768), ($769, $770), ($771, $772), ($773, $774), ($775, $776), ($777, $778), ($779, $780), ($781, $782), ($783, $784), ($785, $786), ($787, $788), ($789, $790), ($791, $792), ($793, $794), ($795, $796), ($797, $798), ($799, $800), ($801, $802), ($803, $804), ($805, $806), ($807, $808), ($809, $810), ($811, $812), ($813, $814), ($815, $816), ($817, $818), ($819, $820), ($821, $822), ($823, $824), ($825, $826), ($827, $828), ($829, $830), ($831, $832), ($833, $834), ($835, $836), ($837, $838), ($839, $840))
1341	481.6 ms	11.6 ms	0.4 ms	1206	SELECT members.id FROM members WHERE members.id BETWEEN $1 AND $2 AND members.id >= $3 ORDER BY members.id ASC LIMIT $4 OFFSET $5
135	29.8 ms	3.5 ms	0.2 ms	135	UPDATE batched_background_migration_jobs SET updated_at = $1, finished_at = $2, status = $3, metrics = $4 WHERE batched_background_migration_jobs.id = $5
270	45.8 ms	3.0 ms	0.2 ms	270	INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
135	25.6 ms	2.3 ms	0.2 ms	135	UPDATE batched_background_migration_jobs SET updated_at = $1, started_at = $2, status = $3, attempts = $4 WHERE batched_background_migration_jobs.id = $5
135	13.1 ms	1.3 ms	0.1 ms	135	SELECT sum(batched_background_migration_jobs.batch_size) FROM batched_background_migration_jobs WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)
270	12.5 ms	0.7 ms	0.0 ms	270	SELECT batched_background_migration_jobs.* FROM batched_background_migration_jobs WHERE batched_background_migration_jobs.id = $1 LIMIT $2
135	4.6 ms	0.1 ms	0.0 ms	135	SELECT members.id FROM members WHERE members.id BETWEEN $1 AND $2 ORDER BY members.id ASC LIMIT $3

Histogram of batch runtimes for BackfillSeatAssignmentsTable

Batch Runtime	Count
0 seconds - 10 seconds	70
10 seconds - 1 minute	65
1 minute - 2 minutes	0
2 minutes - 3 minutes	0
3 minutes - 5 minutes	0
5 minutes +	0

Histogram across all sampled batches of BackfillSeatAssignmentsTable

Query Runtime	Count
0 seconds - 0.1 seconds	875
0.1 seconds - 0.5 seconds	5301
0.5 seconds - 1 second	195
1 second - 2 seconds	69
2 seconds - 5 seconds	0
5 seconds +	0

#### Other information

Other migrations pending on GitLab.com

Migration	Type	Total runtime	DB size change
20241217100247 - CreateMergeRequestApprovalMetrics	Regular	5.6 s	+32.00 KiB
20241219215558 - AddProjectsDeletedToBannedUsers	Regular	6.2 s	+0.00 B
20250108095918 - CreateAiDuoChatEvents	Regular	5.1 s	+8.00 KiB ^[note]
20250109140113 - CreateSecurityPipelineExecutionPolicyConfigLinks	Regular	5.3 s	+48.00 KiB
20250109164501 - CreateCiInstanceRunnerMonthlyUsages	Regular	8.0 s	+40.00 KiB
20250109164504 - CreateCiGitlabHostedRunnerMonthlyUsages	Regular	7.6 s	+56.00 KiB
20250110162455 - AddDefaultValueToMaxHoursBeforeTerminationColumn	Regular	5.2 s	+0.00 B
20250113110737 - CreateSecurityPipelineExecutionSchedules	Regular	5.5 s	+48.00 KiB
20250113110741 - AddSecurityPolicyIdToSecurityPipelineExecutionSchedules	Regular	6.1 s	+0.00 B
20250113110743 - AddProjectsForeignKeyToSecurityPipelineExecutionSchedules	Regular	6.0 s	+0.00 B
20250113122443 - AddForeignKeyToSecurityPipelineExecutionPolicyConfigLinksProjectId	Regular	6.0 s	+0.00 B
20250113165441 - AddForeignKeyToSecurityPipelineExecutionPolicyConfigLinksPolicyId	Regular	6.0 s	+0.00 B
20250114084738 - AddTargetProjectForeignKeyToMergeRequestApprovalMetrics	Regular	6.0 s	+0.00 B
20250119131245 - AddUsedStorageBytesUpdatedAtAndLastIndexedAtToZoektIndices	Regular	5.6 s	+0.00 B
20250120140649 - AddIndexStorageBytesUpdatedAtGtLastIndexedAtToZoektIndices	Regular	6.7 s	+104.00 KiB
20250120152521 - RemoveZoektNamespaceInitialIndexingWorker	Regular	4.7 s	+0.00 B
20250120164332 - CreateQueriesServicePing	Regular	6.1 s	+48.00 KiB
20250121105317 - MakeAccessLevelsOnProtectionTagRulesNullable	Regular	5.5 s	+0.00 B
20250121134358 - AddMultiColumnNotNullConstraintOnProtectionTagRules	Regular	6.3 s	+0.00 B
20250103051831 - EnableReadComplianceDashboard	Post deploy	5.1 s	+536.00 KiB
20250106075603 - ReplacePeriodOnOrganizationPath	Post deploy	5.2 s	+0.00 B
20250106194913 - FinalizeBackfillComplianceViolationNullTargetProjectIdsMigration	Post deploy	5.7 s	+0.00 B
20250108125954 - AddAlertManagementAlertUserMentionsProjectIdNotNullConstraint	Post deploy	6.5 s	+0.00 B
20250109053324 - AddDoraDailyMetricsProjectIdNotNullConstraint	Post deploy	23.7 s	+40.00 KiB
20250109064713 - AddDesignManagementDesignsNamespaceIdNotNullConstraint	Post deploy	6.6 s	+0.00 B
20250109070247 - AddOperationsStrategiesUserListsProjectIdNotNullConstraint	Post deploy	6.3 s	+0.00 B
20250109073325 - AddVulnerabilityUserMentionsProjectIdNotNullConstraint	Post deploy	6.3 s	+0.00 B
20250110082357 - AddUserAchievementsNamespaceIdNotNullConstraint	Post deploy	6.3 s	+0.00 B
20250110151716 - FinalizeRestoreOptInToGitlabCom	Post deploy	5.7 s	+0.00 B
20250113060954 - EnsureBackfillForPipelineMessages	Post deploy	4.8 s	+8.00 KiB ^[note]
20250113060958 - SyncIndexesForCiPipelineMessagesProjectId	Post deploy	5.5 s	+0.00 B
20250113061914 - AddPrepareNotNullConstraintForPipelineMessagesProjectId	Post deploy	7.0 s	+0.00 B
20250113104738 - ValidateProjectsOrganizationIdNotNullConstraint	Post deploy	5.6 s	+0.00 B
20250113123814 - AddIndexToVulnerabilityStateTransitionsForResolvedActivity	Post deploy	4.7 s	+0.00 B
20250113181303 - FinalizeBackfillOnboardingStatusRole	Post deploy	5.6 s	+0.00 B
20250113204448 - FinalizeResyncHasVulnerabilities	Post deploy	5.7 s	+0.00 B
20250113222525 - FinalizeEventsShardingKeyBackfill	Post deploy	5.6 s	+0.00 B
20250113223107 - ValidateCheckEventsShardingKeyIsNotNull	Post deploy	1091.6 s	+0.00 B
20250114123249 - RetruncateSubscriptionSeatAssignments	Post deploy	5.1 s	-3.43 GiB
20250114123402 - RequeueBackfillSeatAssignmentsTable	Post deploy	6.4 s	+0.00 B
20250114140739 - PrepareNoteableIdNoteableTypeAndIdIndexInNotesTable	Post deploy	7.3 s	+0.00 B
20250114182955 - AddIndexReassignToImportSourceUserPlaceholderReferences	Post deploy	159.6 s	+2.25 GiB
20250114193148 - ScheduleUniqueIndexLfsObjectsProjectsWithoutRepositoryType	Post deploy	6.1 s	+0.00 B
20250114213926 - FinalizeMigrateSoftwareLicenseWithoutSpdxIdentifierToCustomLicenses	Post deploy	5.5 s	+0.00 B
20250114232802 - FinalizeBackfillExternalStatusChecksProtectedBranchesProjectId	Post deploy	6.8 s	+0.00 B
20250115085553 - FinalizeBackfillPackagesNugetSymbolsProjectId	Post deploy	5.6 s	+0.00 B
20250115090013 - AddNotNullConstraintToPackagesNugetSymbolsProjectId	Post deploy	6.7 s	+0.00 B
20250115095734 - DropVirtualRegistriesPackagesMavenCachedResponses	Post deploy	4.9 s	-1.56 MiB
20250115122257 - DropStageColumnFromCiBuilds	Post deploy	5.0 s	+0.00 B
20250115233112 - FinalizeBackfillPackagesConanMetadataProjectId	Post deploy	5.5 s	+0.00 B
20250115233143 - FinalizeBackfillPackagesDebianGroupArchitecturesGroupId	Post deploy	5.3 s	+0.00 B
20250116141019 - RemoveForeignKeyOnProvisionSyncs	Post deploy	5.7 s	+0.00 B
20250116141551 - DropTableSubscriptionProvisionSyncs	Post deploy	5.0 s	-32.00 KiB
20250117043431 - AddSbomOccurrencesVulnerabilitiesProjectIdNotNullConstraint	Post deploy	5.8 s	+0.00 B
20250117043556 - PrepareSbomOccurencesVulnerabilitiesProjectIdNotNullValidation	Post deploy	5.7 s	+0.00 B
20250117065245 - AddVulnerabilityFindingEvidencesProjectIdNotNullConstraint	Post deploy	5.8 s	+0.00 B
20250117065246 - PrepareVulnerabilityFindingEvidencesProjectIdValidation	Post deploy	5.6 s	+0.00 B
20250117101822 - ValidateForeignKeyForNamespacesOrganizationId	Post deploy	5.4 s	+0.00 B
20250120132732 - RemoveIndexOnVulnerabilitiesDetectedAtAndId	Post deploy	7.0 s	-4.11 GiB
20250122192623 - FinalizeBackfillResourceLinkEventsAttempt2	Post deploy	5.7 s	+0.00 B

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
`database-testing-4121513-16926849-main`	2025-01-24T07:00:09Z	2025-01-19T06:03:55Z	2025-01-24 20:13:57 +0000
`database-testing-4121513-16926849-ci`	2025-01-24T07:00:09Z	2025-01-22T19:34:58Z	2025-01-24 20:13:57 +0000

Job artifacts

Database migrations (on the ci database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint	Post deploy	7.7 s		+0.00 B
20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation	Post deploy	7.7 s		+0.00 B

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	0
0.1 seconds - 1 second	9
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint

* Type: Post deploy
* Duration: 7.7 s
* Database size change: +0.00 B

Calls

Total Time

Max Time

Mean Time

Rows

Query

1

2.5 ms

1

SELECT c.is_nullable
  FROM information_schema.columns c
  WHERE c.table_schema = $1 AND c.table_name = $2 AND c.column_name = $3

1

1.2 ms

0

ALTER TABLE work_item_parent_links ADD CONSTRAINT check_e9c0111985 CHECK ( namespace_id IS NOT NULL ) NOT VALID

2

0.0 ms

2

SELECT pg_backend_pid()

Histogram for AddWorkItemParentLinksNamespaceIdNotNullConstraint

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	0
0.1 seconds - 1 second	4
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation

* Type: Post deploy
* Duration: 7.7 s
* Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
1	0.1 ms	0.1 ms	0.1 ms	1	INSERT INTO "postgres_async_foreign_key_validations" ("created_at", "updated_at", "name", "table_name", "constraint_type") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
1	0.0 ms	0.0 ms	0.0 ms	0	SELECT "postgres_async_foreign_key_validations".* FROM "postgres_async_foreign_key_validations" WHERE "postgres_async_foreign_key_validations"."constraint_type" = $1 AND "postgres_async_foreign_key_validations"."name" = $2 AND "postgres_async_foreign_key_validations"."table_name" = $3 LIMIT $4
1	0.0 ms	0.0 ms	0.0 ms	0	SELECT $1 AS one FROM "postgres_async_foreign_key_validations" WHERE "postgres_async_foreign_key_validations"."name" = $2 AND "postgres_async_foreign_key_validations"."table_name" = $3 LIMIT $4
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for PrepareWorkItemParentLinksNamespaceIdNotNullValidation

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	0
0.1 seconds - 1 second	5
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

Other migrations pending on GitLab.com

Migration	Type	Total runtime	DB size change
20241217100247 - CreateMergeRequestApprovalMetrics	Regular	8.7 s	+24.00 KiB
20250109140113 - CreateSecurityPipelineExecutionPolicyConfigLinks	Regular	7.6 s	+48.00 KiB
20250109164501 - CreateCiInstanceRunnerMonthlyUsages	Regular	8.9 s	+48.00 KiB
20250109164504 - CreateCiGitlabHostedRunnerMonthlyUsages	Regular	8.8 s	+40.00 KiB
20250113122443 - AddForeignKeyToSecurityPipelineExecutionPolicyConfigLinksProjectId	Regular	8.0 s	+8.00 KiB ^[note]
20250113165441 - AddForeignKeyToSecurityPipelineExecutionPolicyConfigLinksPolicyId	Regular	7.9 s	+0.00 B
20250114084738 - AddTargetProjectForeignKeyToMergeRequestApprovalMetrics	Regular	8.1 s	+0.00 B
20250120152521 - RemoveZoektNamespaceInitialIndexingWorker	Regular	6.8 s	+0.00 B
20250120164332 - CreateQueriesServicePing	Regular	8.4 s	+48.00 KiB
20250121105317 - MakeAccessLevelsOnProtectionTagRulesNullable	Regular	7.3 s	+0.00 B
20250121134358 - AddMultiColumnNotNullConstraintOnProtectionTagRules	Regular	8.1 s	+0.00 B
20250103051831 - EnableReadComplianceDashboard	Post deploy	6.8 s	+0.00 B
20250106075603 - ReplacePeriodOnOrganizationPath	Post deploy	7.0 s	+0.00 B
20250108125954 - AddAlertManagementAlertUserMentionsProjectIdNotNullConstraint	Post deploy	8.3 s	+0.00 B
20250113123814 - AddIndexToVulnerabilityStateTransitionsForResolvedActivity	Post deploy	6.9 s	+0.00 B
20250113204448 - FinalizeResyncHasVulnerabilities	Post deploy	6.8 s	+0.00 B
20250113222525 - FinalizeEventsShardingKeyBackfill	Post deploy	6.8 s	+0.00 B
20250113223107 - ValidateCheckEventsShardingKeyIsNotNull	Post deploy	7.4 s	+0.00 B
20250114140739 - PrepareNoteableIdNoteableTypeAndIdIndexInNotesTable	Post deploy	9.3 s	+8.00 KiB ^[note]
20250114193148 - ScheduleUniqueIndexLfsObjectsProjectsWithoutRepositoryType	Post deploy	8.0 s	+0.00 B
20250115233112 - FinalizeBackfillPackagesConanMetadataProjectId	Post deploy	6.8 s	+0.00 B
20250117065245 - AddVulnerabilityFindingEvidencesProjectIdNotNullConstraint	Post deploy	7.8 s	+0.00 B
20250117065246 - PrepareVulnerabilityFindingEvidencesProjectIdValidation	Post deploy	7.8 s	+0.00 B
20250117101822 - ValidateForeignKeyForNamespacesOrganizationId	Post deploy	7.5 s	+0.00 B
20250122192623 - FinalizeBackfillResourceLinkEventsAttempt2	Post deploy	6.6 s	+0.00 B

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
`database-testing-4121513-16926849-main`	2025-01-24T07:00:09Z	2025-01-19T06:03:55Z	2025-01-24 20:13:57 +0000
`database-testing-4121513-16926849-ci`	2025-01-24T07:00:09Z	2025-01-22T19:34:58Z	2025-01-24 20:13:57 +0000

Job artifacts

Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

changed the description

added database-testing-automation label

changed title from Draft: Add NOT NULL constraint on work_item_parent_links.namespace_id to Draft: Add NOT NULL for sharding key on work_item_parent_links

changed the description

added 2486 commits

8bf017db...24d7ebd9 - 2485 commits from branch master
0c0b9d1d - Add NOT NULL constraint on work_item_parent_links.namespace_id

Compare with previous version

added 538 commits

0c0b9d1d...7fce88df - 537 commits from branch master
be003fa3 - Add NOT NULL constraint on work_item_parent_links.namespace_id

Compare with previous version

Hi @shubhamkrai , could you please help with the initial review for this? Thank you!

marked this merge request as ready

removed workflowready for development label

requested review from @shubhamkrai

approved this merge request

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

Hello @Quintasan could you do the final review for this?

requested review from @Quintasan

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 14cc21b8

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 138    | 0      | 20      | 0     | 158   | ✅     |
| Govern      | 79     | 0      | 13      | 0     | 92    | ✅     |
| Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
| Verify      | 52     | 0      | 20      | 1     | 72    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 430    | 0      | 125     | 1     | 555   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 14cc21b8

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 143    | 0      | 19      | 0     | 162   | ✅     |
| Verify      | 53     | 0      | 19      | 0     | 72    | ✅     |
| Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 448    | 0      | 123     | 0     | 571   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

approved this merge request

added databaseapproved label and removed databasereview pending label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label

enabled automatic add to merge train when checks pass

resolved all threads

Hey there , could you please make sure this merge request gets merged?

The merge request is set to auto-merge, but it is not currently mergeable (MR detailed_merge_status is conflict).

This message was generated automatically. Improve it or delete it.

aborted automatic add to merge train because the source branch was updated. Learn more.

added 518 commits

be003fa3...a898f543 - 517 commits from branch master
14cc21b8 - Add NOT NULL constraint on work_item_parent_links.namespace_id

Compare with previous version

reset approvals from @Quintasan by pushing to the branch

Hi @Quintasan, I had to to fix a conflict which reset your approval. Could you please look into this again? Thank you!

requested review from @Quintasan

approved this merge request

started a merge train

merged

Hello @smaglangit

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

@gitlab-org/database-team

And someone will be by shortly!

Thanks for your help!

This message was generated automatically. Improve it or delete it.

mentioned in commit 9011c792

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#10221 (closed)

added workflowstaging-canary label

no schema change; no impact to data warehouse

added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

Add NOT NULL for sharding key on work_item_parent_links

What does this MR do and why?

References

MR acceptance checklist

Screenshots or screen recordings

How to set up and validate locally

Activity

Reviewer roulette

Database migrations (on the main database)

Migration: 20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint

Migration: 20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation

Background Migration: BackfillSeatAssignmentsTable

Database migrations (on the ci database)

Migration: 20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint

Migration: 20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation

Other information

Before you set this MR to auto-merge

E2E Test Result Summary

Add NOT NULL for sharding key on work_item_parent_links

What does this MR do and why?

References

MR acceptance checklist

Screenshots or screen recordings

How to set up and validate locally

Merge request reports

Activity

Reviewer roulette

Database migrations (on the main database)

Migration: 20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint

Migration: 20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation

Background Migration: BackfillSeatAssignmentsTable

Database migrations (on the ci database)

Migration: 20250124055844 - AddWorkItemParentLinksNamespaceIdNotNullConstraint

Migration: 20250124055903 - PrepareWorkItemParentLinksNamespaceIdNotNullValidation

Other information

Before you set this MR to auto-merge

E2E Test Result Summary