Draft: Resolve cross-join in EE::Group#vulnerability_scanners
What does this MR do and why?
Remove cross-database join from EE::Group#vulnerability_scanners.
It uses vulnerability_reads.traversal_ids column to SELECT project IDs of a the group and its subgroup.
As a consequence, #vulnerability_scanners now returns scanners
of projects that been archived or that are marked for deletion.
This behavior changed as been discussed in #486216 (comment 2284741593).
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
#vulnerability_scanners(2 options)
- Leverage
Vulnerabilities::Read, but then we might have get scanners of projects that have been archived and projects that are being deleted. See #486216 (comment 2277842828)- Use mirrors of
projectsandnamespacestable, in which case he issue is blocked by Ensure Sec DB remains in sync with CI mirror ta... (#466288 - closed). See #466288 (comment 2277169356)
This MR implements the first approach.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.