Skip to content

Use integration testing with auditing code in runner specs

What does this MR do and why?

This MR changes the EE tests to use integration testing when performing operations on runners, to expose any bugs in auditing code. This is a corrective action for 2 recent incidents (gitlab-com/gl-infra/production#18984 (closed) and the related https://gitlab.com/gitlab-com/gl-infra/production/-/issues/18994). The approach taken here corresponds to #509082 (closed).

For context, the original problem was that the Gitlab::Audit::CiRunnerTokenAuthor class was missing the #impersonated? method, so tracking that event caused a NoMethodError.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Edited by Pedro Pombeiro

Merge request reports

Loading