Skip Exclusive Lease Transaction Check for js specs
What does this MR do and why?
When transactional tests are enabled, we may run into issues with Gitlab::ExclusiveLease which is not expected to be run within transactions.
To avoid false positives, disable this check for JavaScript feature specs run.
Similar MR: !163832 (merged)
Merge request reports
Activity
assigned to @marc_shaw
added pipelinetier-1 label
- A deleted user
added backend label
2 Warnings 
642f4973: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. 1 Message 
CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelogtrailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @aluthra2(UTC+5.5, 4.5 hours ahead of author)
@mwoolf(UTC+0, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Resolved by Marc Shaw
@marc_shaw- please see the following guidance and update this merge request.1 Error 
Please add typebug typefeature, or typemaintenance label to this merge request.
added maintenancetest-gap label
added typemaintenance label
added 403 commits
-
642f4973...32fedda7 - 402 commits from branch
master - 9078ea83 - wip
-
642f4973...32fedda7 - 402 commits from branch
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelogtrailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @davidhampgonsalves(UTC-4, 12 hours behind author)
@manojmj(UTC+5.5, 2.5 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
added 1 commit
- e927351c - Skip Exclusive Lease Transaction Check for js specs
changed milestone to %17.8
added 1 commit
- 52ef1968 - Skip Exclusive Lease Transaction Check for js specs
- Resolved by Stan Hu
We previously had a discussion here (!167702 (comment 2236410724))
Any thoughts about this MR ?
- Last reply by Marc Shaw
mentioned in merge request !167702 (closed)
changed milestone to %17.9
added missed:17.8 label
added 3864 commits
-
52ef1968...e3b7f13a - 3863 commits from branch
master - f87f70a3 - Skip Exclusive Lease Transaction Check for js specs
-
52ef1968...e3b7f13a - 3863 commits from branch
changed milestone to %17.10
added missed:17.9 label
added 4125 commits
-
2125b19c...ef201489 - 4123 commits from branch
master - 1d3c56f3 - Skip Exclusive Lease Transaction Check for js specs
- 7af576d1 - wip
-
2125b19c...ef201489 - 4123 commits from branch
added 1 commit
- 71bac489 - Skip Exclusive Lease Transaction Check for js specs
requested review from @stanhu
added pipelinetier-3 label and removed pipelinetier-1 label
E2E Test Result Summary
allure-report-publishergenerated test report!e2e-test-on-cng:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 52 | 0 | 20 | 0 | 72 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Create | 140 | 0 | 22 | 0 | 162 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 3 | 0 | 5 | 0 | 8 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 445 | 0 | 127 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 82 | 0 | 1 | 0 | 83 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Govern | 77 | 0 | 3 | 0 | 80 | ✅ | | Create | 130 | 0 | 3 | 0 | 133 | ✅ | | Data Stores | 33 | 0 | 0 | 0 | 33 | ✅ | | Verify | 51 | 0 | 2 | 0 | 53 | ✅ | | Monitor | 8 | 0 | 1 | 0 | 9 | ✅ | | Secure | 5 | 0 | 0 | 0 | 5 | ✅ | | Package | 24 | 0 | 0 | 0 | 24 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 420 | 0 | 10 | 0 | 430 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+Edited by ****added pipeline:mr-approved label
LGTM, thanks @marc_shaw
started a merge train
mentioned in commit 645c1989
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in issue #451674 (closed)
